Maybe the rationale is that this dependency is not seen as a big problem since workflow-plugin is actually composed of many different plugins, and that that one is more a library plugin. Hence that's not gonna install the workflowJob type in a unintentional manner?
2015-10-09 15:35 GMT+02:00 Kanstantsin Shautsou <[email protected]>: > СС jglick > > On Oct 9, 2015, at 16:33, Manuel Jesús Recena Soto <[email protected]> > wrote: > > Hello, > > As I said here [1], I'll review this dependency. But IIRC, It is necessary > and is well configured. > > Regards, > > [1] > https://github.com/jenkinsci/ssh-agent-plugin/pull/4#discussion_r41622070 > > 2015-10-09 10:49 GMT+02:00 Baptiste Mathus <[email protected]>: > >> Hi, >> >> This dates from this commit back from 2015-08-24 by Manuel Recena: >> https://github.com/jenkinsci/ssh-agent-plugin/commit/010e968ab2ff8efa23a51d56d9046329140c96b5 >> from this PR https://github.com/jenkinsci/ssh-agent-plugin/pull/4 >> >> IIUC, this PR was supposed to add ssh-agent steps to DSL. Hence, IMO this >> is an example where the dependency from ssh-agent to workflow should have >> been added with <optional>true</optional> [1]. >> >> Manuel, did you make dependency required on purpose? >> >> Cheers >> >> 2015-10-09 10:19 GMT+02:00 Victor Martinez <[email protected] >> >: >> >>> Hi again, >>> >>> In order to support the workflow plugin those dependent modules should >>> be part of every plugin? If that's the case, is there any planning to add >>> those features as part of the jenkins core? I like the idea of reducing the >>> dependencies between plugins in order to use the Configuration as Code >>> paradigm without worrying about those dependent plugins >>> >>> Thanks again >>> >>> On Friday, 9 October 2015 10:03:47 UTC+2, Victor Martinez wrote: >>>> >>>> Hi there, >>>> >>>> I'd like to know whether the ssh-agent plugin dependencies are wrong >>>> or not >>>> >>>> Latest Release >>>> Latest Release Date >>>> Required Core >>>> Dependencies1.8 <http://updates.jenkins-ci.org/latest/ssh-agent.hpi> ( >>>> archives) <http://updates.jenkins-ci.org/download/plugins/ssh-agent/> >>>> Aug 07, 2015 >>>> 1.609.1 >>>> <http://updates.jenkins-ci.org/download/war/1.609.1/jenkins.war> >>>> ssh-credentials >>>> <https://wiki.jenkins-ci.org/display/JENKINS/SSH+Credentials+Plugin> ( >>>> version:1.11) >>>> credentials >>>> <https://wiki.jenkins-ci.org/display/JENKINS/Credentials+Plugin> ( >>>> version:1.22) >>>> workflow-step-api >>>> <https://wiki.jenkins-ci.org/display/JENKINS/Workflow+Plugin> (version: >>>> 1.9) >>>> >>>> I wonder why those workflow-step-api plugin dependencies are there, >>>> I've found the below Jira: >>>> https://issues.jenkins-ci.org/browse/JENKINS-28689 But still I don't >>>> understand why those workflow steps plugin might be part of the ssh-agent. >>>> Basically I use puppet to configure Jenkins and its dependencies and now >>>> I'm forced somehow to install that new version and also its dependencies, >>>> and I don't like the way of having a bunch of new plugin dependencies >>>> >>>> Just wondering if that's the expected behaviour or so >>>> >>>> Thanks so much >>>> >>>> >>>> >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/2546f42f-2e1f-4aac-975a-f3dfd5e8eda1%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/2546f42f-2e1f-4aac-975a-f3dfd5e8eda1%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Baptiste <Batmat> MATHUS - http://batmat.net >> Sauvez un arbre, >> Mangez un castor ! >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7%3Dy1Rd_bwBThRmzR1_MyP8Q0c4YPsg5zVKLh%3DdXgAuAw%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7%3Dy1Rd_bwBThRmzR1_MyP8Q0c4YPsg5zVKLh%3DdXgAuAw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Manuel Recena Soto > * manuelrecena.com [/blog] > * linkedin.com/in/recena > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/K7pf_W8NgqA/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CABa-UodU016ayyyku8eN%3DZ6jYwvmV5TMXU%3Dd9OPQxqbZPZGpZg%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CABa-UodU016ayyyku8eN%3DZ6jYwvmV5TMXU%3Dd9OPQxqbZPZGpZg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/4B880F5C-D771-4D91-8CFC-2CFE715DF869%40gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/4B880F5C-D771-4D91-8CFC-2CFE715DF869%40gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- Baptiste <Batmat> MATHUS - http://batmat.net Sauvez un arbre, Mangez un castor ! -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS7ErxSQY2E6ObBCpO2vXXZpWL2o81E%2BayEsgygT4AHFsg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
