On Monday, October 19, 2015 at 9:19:44 PM UTC+2, Jesse Glick wrote: > > On Mon, Oct 19, 2015 at 2:19 PM, Kohsuke Kawaguchi <[email protected] > <javascript:>> wrote: > > Queue.Item.id has known fixed set of subtypes, so we can restrict the > rewrite to a much smaller subset. > > Not sure I follow that. IIUC the problem is outside references to > `id`. The number of subtypes of `Item` (and the fact that they are all > in core) is irrelevant. >
All we know is that class X has a field called `id` In order to see if it is truly Item.id being referenced you need to load all the subclasses of X and walk them (we are back to loading subclassess in the classloader - eek) https://github.com/jenkinsci/bytecode-compatibility-transformer/blob/master/src/main/java/org/jenkinsci/bytecode/TransformationSpec.java#L23-L30 > if we want to discourage the use of BCT, we can do that, too. > > I think to gain the benefits it has to be completely removed, not just > “discouraged”. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bf6ca3e8-be3e-49a4-8faa-4c6b3ee4d0ea%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
