> > I have some concerns about mandating a tidy-up (I note that Jesse is > against rewriting the history of a PR branch as that means that GitHub > hides the code review comments) >
Can you explain this. If I pushed a rebased commit the comments are still there with "commented on an outdated diff" (and if the comment is still applicable to the LOC is still shows) [1] This is no different to comments on a commit being addressed in a future commit and as such are still visible? /James [1] or so it seemed when I have done this before... -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/43ed9f06-924d-4912-9389-200590b78ac8%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
