On Tue, Oct 27, 2015 at 6:58 PM, Ikedam <[email protected]> wrote: > https://wiki.jenkins-ci.org/display/JENKINS/Preview+for+Copy+Artifact+2.0
Very nice. Some technical comments: > VirtualFile (ArtifactManager) doesn't support listing files with ant file > patttens (like */.java) Does `String[] list(String glob)` not work as advertised? > copy artifacts from generic ArtifactManager. This doesn't preserver file > modes and symbolic links (as VirtualFile doesn't provide that feature) Not currently, but you should file a PR to let it! (Or better, just let it create a TAR stream.) And you should not allow users to specifically request a copier for `StandardArtifactManager`, since we expect that such features would be added to the API in the future. Instead, there should be one `ArtifactManager` copier, which *currently* will need to check for `instanceof StandardArtifactManager` and specially handle file modes/links/etc., but which will in the future call standard API methods. > TriggeringBuildSelector may cause performance issues. > It tracks and lists all upstream builds to enumerate upstream builds. > Generator pattern should be useful for this case but I couldn't find common > and reliable implementation for that. Plenty of Jenkins code lazily enumerates builds. There is a whole series of helper methods in `RunList`. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2xmtE2dF%2B4oCt85JJamhsmr4x58xtyCEdFp%2B4%3D5p2AWg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
