Hi Oleg,

sorry for the very long break! Had been really busy on work and had to do some business trips. I'd be grateful if you create a repo for the node-cleanup-plugin. You proposed a review of my plugin code but unfortunately I don't know the review process, so how to trigger a review?

About the custom script scm plugin I'll check if it could be integrated into the script scm plugin. I understand the issue not having to many plugins to make it easier for users to find the right plugin. On the other hand having separate plugins for separate things might also be helpful? Really not sure what is the best solution here.

Once again, thanks for your support.

Kind Regards, Andreas


Am 10.10.2015 um 09:34 schrieb Oleg Nenashev:
Hi Andreas,

Thanks a lot for your patience and detailed answers!
I'm OK with node-cleanup-plugin. I'll fork it today.

Regarding the "custom-script-scm-plugin", I would vote for extending
Script SCM plugin (https://issues.jenkins-ci.org/browse/JENKINS-28472)
and deprecating the existing shell-script-plugin.

BTW, I also agree if you want to create a separate plugin. Then...

  * Script SCM Plugin could be renamed to Groovy System Script SCM Plugin
  * The old plugin https://github.com/jenkinsci/shell-script-scm-plugin
    can be deprecated or replaced by the new code if Jesse Farinacci
    agrees (in Cc)
  * I'll create "custom-script-scm-plugin" repo. If there is a response
    from Jesse, we can always move the code

BR, Oleg


--
You received this message because you are subscribed to the Google Groups "Jenkins 
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/BLU437-SMTP142999CF050095AB6BDD2AD1160%40phx.gbl.
For more options, visit https://groups.google.com/d/optout.

Reply via email to