Hi Yoann, Thank you for your response. > I was wondering what was missing to rewrite a simplified version of it.
So here are couple of things that I found needed to be changed 1. changed to use spotify-docker api client instead of command line, I needed it to talk to docker-swarm to allocated nodes 2. Slaves are allocated based on job label not job property, much like cloud plugins 3. We didn't need to run builds in another image/side image ect, we use docker-compose to run builds. 4. Had to remove couple of hacks like this <https://github.com/ndeloof/docker-slaves-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/dockerslaves/DockerComputerLauncher.java#L84>, since we don't store builds on disk. 5. We didn't need jenkins user mounting . This plugin simply allocates a new slave via jnlp/docker api calls. There is no extra magic. Surya On Sunday, December 13, 2015 at 12:53:44 PM UTC-6, Surya Gaddipati wrote: > > This is not a hosting request. I am hoping to get some feedback on the > plugin and see if its worth hosting/merging into other plugins. > > Details are in the readme of the project > https://github.com/suryagaddipati/jenkins-docker-slaves > > > Pls, let me know if you have any questions. > > Surya > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/57db95e2-f8df-4015-9d91-3705a852aa3d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
