Janario and others, I want to add workflow support to the http-request-plugin <https://wiki.jenkins-ci.org/display/JENKINS/HTTP+Request+Plugin>. As you are the author of the plugin, I would like your feedback on the following:
1. Some items are marked as "to be deprecated" in the global config. I am proposing to deprecate them, so there are fewer features to worry about. 2. Baseline version: from 1.509.4 to 1.609.1: workflow support requires a baseline upgrade. Is it a concern to upgrade the baseline? 3. I prepared a pull-request <https://github.com/jenkinsci/http-request-plugin/pull/13>, can you please review it? 4. Default values in the jelly forms are not linked to default values in the DescriptorImpl, and sometimes differ. This is a bit confusing, as default values in testing are not the same as the default plugin values when using the plugin, I want the change the jelly forms to read the defaults from the DescriptorImpl. The plan I am following is to propose TWO pull requests: 1. Pull-request 1: Workflow readiness preparation (see https://github.com/jenkinsci/http-request-plugin/pull/13) 1. Add tests 2. Format the code according to the Workflow COMPATIBILITY.md <https://github.com/jenkinsci/workflow-plugin/blob/master/COMPATIBILITY.md#constructor-vs-setters> guidelines 3. Align jelly form default values to DescriptorImpl default values (not yet present in the pull-request) 4. Release a working version of the plugin 2. Pull-request 2: Implement a custom workflow step (to be written as soon as I understand how to do it) 1. Instead of calling the plugin from a generic "step()" call, support a custom step for the plugin (httpRequest). 2. Add workflow specific tests 3. Send pull-request, respond/implement feedback 4. Release Thanks, Martin -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/abd411ec-9afa-4f0a-b21f-080ff73351b8%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
