Done 2016-03-08 2:33 GMT-08:00 Manuel Jesús Recena Soto <[email protected]>:
> By the way Kohsuke, when you have a chance, create the Jira component > for this plugin. I have to move there these issues: > > https://issues.jenkins-ci.org/browse/JENKINS-33242 > https://issues.jenkins-ci.org/browse/JENKINS-32155 > https://issues.jenkins-ci.org/browse/JENKINS-33243 > etc... > > Regards, > > 2016-03-08 10:16 GMT+01:00 Manuel Jesús Recena Soto <[email protected]>: > > Hello Kohsuke, > > > > After knowing that the widespread idea is to use `github-plugin` so > > that GitHub configuration is managed by this plugin, I think that my > > last PR to `github-branch-source` does not make sense. > > > > When I pushed this PR my goal was to improve (or try to do it) the > > current form validation when the use sets a GitHub Enterpise server. > > Only that. > > > > Do you (KK, Jesse, Christopher, others...) agree if I close this PR? > > > > Regards, > > > > 2016-03-08 5:43 GMT+01:00 Kohsuke Kawaguchi <[email protected]>: > >> Patrick told me that https://issues.jenkins-ci.org/browse/JENKINS-33228 > >> discusses this very issue. > >> > >> 2016-03-07 18:58 GMT-08:00 Kohsuke Kawaguchi <[email protected]>: > >>> > >>> Oh no, it's coming from GitHub Branch Source plugin! > >>> > >>> 2016-03-07 18:40 GMT-08:00 Kohsuke Kawaguchi <[email protected]>: > >>>> > >>>> > >>>> > >>>> 2016-03-07 18:07 GMT-08:00 Kohsuke Kawaguchi <[email protected]>: > >>>>>> > >>>>>> e.g. this image shows (part of) what a user will see on the system > >>>>>> config page if they install the GitHub-related plugins that will be > >>>>>> recommended by Jenkins 2.0: > >>>>>> http://i.imgur.com/0Iv5lF3.png > >>>>>> > >>>> > >>>> I looked at the fresh install and GitHub Pull Request Builder isn't a > >>>> part of the recommended list of plugins, so while the problem is still > >>>> there, I feel a little better. > >>>> > >>>> I'm still not sure where "GitHub Enterprise Servers" configuration is > >>>> coming from... > >>>> > >>>> > >>>> -- > >>>> Kohsuke Kawaguchi > >>> > >>> > >>> > >>> > >>> -- > >>> Kohsuke Kawaguchi > >> > >> > >> > >> > >> -- > >> Kohsuke Kawaguchi > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "Jenkins Developers" group. > >> To unsubscribe from this group and stop receiving emails from it, send > an > >> email to [email protected]. > >> To view this discussion on the web visit > >> > https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4z4dmuE53Of2b2wzTFEfjVZL2fehBaJ%3DZfyZyeVX86ktw%40mail.gmail.com > . > >> > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > -- > > Manuel Recena Soto > > * manuelrecena.com [/blog] > > * linkedin.com/in/recena > > > > -- > Manuel Recena Soto > * manuelrecena.com [/blog] > * linkedin.com/in/recena > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CABa-UofDBLoLqOgKgJRJVxDhZRQqXRErTdpHT6LqQc3nDP5oWw%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- Kohsuke Kawaguchi -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAN4CQ4yxC72CvFiFf2%2BcJ%3Dvg-zuBzFz0iBK5OpQmjckSsgYOCg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
