In the short term, I don't think you are missing out on anything by using 1.0 while you work out what docker version.
May need to adjust this to work more as expected. On Wednesday, March 9, 2016 at 10:57:53 AM UTC+11, Liam wrote: > > I'm not sure what version of docker is running on the Jenkins machine at > the moment. I'll find out, but that may take a little while. > > Yes, you're correct that bs-api is the directory containing the dockerfile > (the path). In v1.0.1 it was treated as such, but now it's treated as the > path to the Dockerfile (the --file flag). > > We're not really in a position to be able to manually adjust this for all > of our builds, since we've got loads that use this property. > > > On Wednesday, 9 March 2016 12:05:36 UTC+13, Michael Neale wrote: >> >> Some of these changes were due to changes in docker itself - what version >> of docker are you running? >> >> Yes, I suspect the meaning is a subtle change. >> >> So in the past bs-api I guess would have been the PATH. >> The latest cli: >> https://docs.docker.com/engine/reference/commandline/build/ >> >> So according to this, in 1.1 of the plugin, bs-api would be the name of >> your "Dockerfile", which is probably not what you mean? the bs-api was the >> directory that had the Dockerfile in it before if I am right? >> > >> >> On Wednesday, March 9, 2016 at 9:14:45 AM UTC+11, Liam wrote: >>> >>> We're using >>> https://wiki.jenkins-ci.org/display/JENKINS/CloudBees+Docker+Build+and+Publish+plugin >>> >>> to do our docker builds. >>> >>> I've tried to update from v1 -> v1.2, which caused previously successful >>> builds to fail. I went back through and isolated the issue to be the jump >>> from v1.0.1 to v1.1. >>> I didn't alter any of the build configuration during this process. >>> >>> Looking at the logs, it seems like the commands are run differently, >>> despite the lack of change in configuration: >>> v1.0.1: >>> >>> docker build -t lfn3/bs-api:142 --no-cache=true bs-api >>> >>> >>> v1.1 >>> >>> docker build -t lfn3/bs-api:141 --no-cache=true --file=bs-api >>> /var/lib/jenkins/jobs/docker-bs-api/workspace >>> >>> >>> It appears that the parameter that was previously treated as the docker >>> context dir is now passed as the docker file-path. >>> >>> It seems like the field was mis-named in v1.0.1: "Directory dockerfile is >>> in", and I'm guessing it was renamed to something like "Dockerfile name" >>> and a separate context dir was introduced? >>> >>> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0755166d-18da-44c4-97e6-34bf50b6595d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
