Hi Jesse, Ok, will note it in README. Since all Jenkins plugins are self-contained I was thinking that it doesn't worst a mention that outside of the dev mode it differ :)
About the API - well, you're right, I guess... I just prefer to split responsibility into the separate classes, this is why I didn't want to put API method in Action class and decided to provide API instead. Not sure if it's best practice in Jenkins or not thou :) Anyway, thanks for your notes, I will take them into the account :) On Mon, Mar 21, 2016 at 4:23 PM Jesse Glick <[email protected]> wrote: > Looks nice! A nit about the README: it should emphasize that while in > _dev mode_ you need to manually run a separate service and browse to > another URL, the fully built plugin `*.hpi` is self-contained. > > On Mon, Mar 21, 2016 at 2:52 AM, Sergei Egorov <[email protected]> wrote: > > Why Jackson? Because it was much easier to implement serialization of > selected (non-exposed) fields and class info included compared to Stapler. > I saw something were done about classinfo in Stapler, but at the moment of > creation of this plugin, it wasn't delivered to Jenkins core yet. Also, > almost none of the Pipeline actions are @Expose-d. > > BTW there is no apparent purpose in `PipelineViewApi` extending `Api`, > since you are just defining a custom web method anyway, which could > have put directly in `PipelineViewAction`. Maybe I am missing > something here. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0Te6a5_pzm0HnKiz3eGPc7cv%2BWZTE8ibJCB%3DdeOk4_2Q%40mail.gmail.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAJdKX%3Dc4E_XUcLz9Xb3_5Fc05FGOpM-XdQkMohDeQg7%3DLySeQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
