Hello again, Oleg I could use some more advice about how to integrate this feature. If this 7zip-installer is added to ExtraToolInstallers, where in custom tools plugin do you think I should call the 7zip-installer? So far the tracks lead me to hudson.tools.FilePath where an if statement checks whether the archive ends with zip or tar.gz. Source (line 821 and 847): https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/FilePath.java
Should I do any changes there as well or is there any other way to do this? Sincerely, Martin Hjelmqvist Den tisdag 22 mars 2016 kl. 13:19:51 UTC+1 skrev Oleg Nenashev: > > Hi Martin, > > Yes, GSoC is definitely not an option for this year bachelor thesis. > > Are you proposing that I add this feature in the Extra Tool Installers >> Plugin that extends AbstractExtraToolInstaller (which in turn extends >> ToolInstaller)? By extension points, you mean like BatchCommandInstaller >> and SharedDirectoryInstaller? > > > Something like that. Generic Tool installers definitely do not belong to > Custom Tools Plugin from my PoV. > > Just a note on the terminology: > > - Extention Point - ToolInstaller (it extends the ExtensionPoint > interface) > - Extension Point implementation - BatchCommandInstaller, > SharedDirectoryInstaller, > etc. > > BR, Oleg > > 2016-03-22 12:41 GMT+01:00 Martin Hjelmqvist <[email protected] > <javascript:>>: > >> Hi Oleg! >> >> Good to hear! This project is planned to be finished by the end of May >> this year though. >> >> Aha, I need to approach this in another way then. Are you proposing that >> I add this feature in the Extra Tool Installers Plugin that extends >> AbstractExtraToolInstaller (which in turn extends ToolInstaller)? By >> extension points, you mean like BatchCommandInstaller and >> SharedDirectoryInstaller? Trying to get a picture of the structure. :) >> >> Sincerely, >> Martin Hjelmqvist >> >> Den tisdag 22 mars 2016 kl. 11:08:54 UTC+1 skrev Oleg Nenashev: >>> >>> Hi Martin, >>> >>> Great to hear that you're working on this plugin. I'm it's maintainer, >>> so I will try to help where I can. If you consider a long-term project ("if >>> you graduate on the next year"), maybe you would be interested to make a >>> proposal for Google Summer Of Code >>> <https://wiki.jenkins-ci.org/display/JENKINS/Google+Summer+Of+Code+2016>. >>> I think we can find mentors for this project >>> >>> Regarding your question... >>> >>> Actually, "ToolInstallation >>> <http://javadoc.jenkins-ci.org/hudson/tools/ToolInstallation.html>" and >>> "ToolInstaller >>> <http://javadoc.jenkins-ci.org/?hudson/tools/ToolInstaller.html>" are >>> different entities in Jenkins. Custom Tools Plugin provides the >>> ToolInstallation implementation, but it uses standard ToolInstallers being >>> provided by other Jenkins plugins. >>> >>> If you want to add a 7zip ToolInstaller, I think Extra Tool Installers >>> Plugin >>> <https://wiki.jenkins-ci.org/display/JENKINS/Extra+Tool+Installers+Plugin> >>> is the best destination for such feature. You can find examples of >>> extension point implementations there. >>> >>> Best regards, >>> Oleg Nenashev >>> >>> вторник, 22 марта 2016 г., 10:50:10 UTC+1 пользователь Martin Hjelmqvist >>> написал: >>>> >>>> Hello, >>>> >>>> I'm currently working on my bachelor thesis; Improve the Jenkins custom >>>> tools installer. There is a need for a file format able to contain up to >>>> 100GB of installation files, since tar.gz and zip has a size limit of ~8GB >>>> and ~4GB size limit respectively. The idea is to add support for the file >>>> format 7z which currently has a size limit of 16 exabytes and also is >>>> faster to unpack than a zip file. >>>> >>>> Anything I should keep in mind when integrating the extension for this >>>> plugin? So far I have developed code for unpacking a 7z-file through a >>>> string file path, but not sure that will work in the end. >>>> Any thoughts? >>>> >>>> Sincerely, >>>> Martin Hjelmqvist >>>> Bachelor Thesis at HMS Industrial Networks, Sweden >>>> >>> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/74aZNSlm3Yg/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/15de6fd5-4403-40ce-9140-8b5b3b13b071%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/15de6fd5-4403-40ce-9140-8b5b3b13b071%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/18c3cced-f966-41c1-86fa-7b3ea1ae4fcd%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
