Ah ... I didn't look at remodal in detail and so didn't see that it was a jQuery plugin. You'd think that would be the first thing they'd highlight in their docs ;)
So ... the fact that it is a jQuery plugin does complicate things a bit. We do not want to use jQuery in the normal way within Jenkins i.e. expose it as a global. That causes all sorts of problems that are really hard to solve once you go down that road. It has caused problems in Jenkins in the past where we are still living with the consequences now today (e.g. the prototypejs cancer). Anyway ... I'm guessing that remodal assumes there's a jQuery bound to the global scope. We would want remodal to not make that assumption and, instead, get and deocorate it's own instance of jQuery. Doing it that way makes sure that the remodal in use by Jenkins is something that has it's own jQuery (and so no clashes with other jQuery plugins) that's not bound to the global scope i.e. is not going to effect anything else in Jenkins and is not going to be effected by anything else in Jenkins. So, it would mean creating remodal equivalent of bootstrap-detached <https://github.com/tfennelly/bootstrap-detached>. On 30 May 2016 at 09:25, Samat Davletshin <samat...@gmail.com> wrote: > I committed my changes to my fork here. > <https://github.com/samatdav/jenkins/commit/a82ebdbb31063604ad4b6e043232dc632b2068e9> > So do you advise to make a branch and re-upload changes there? > > Regarding the library I just added css and js code to random existing > files (hudson-behavior.js and style.css) for testing, hoping to redo it > later. I was thinking that it is just like bootstrap library - only css and > js files for styling and behavior. Should it be added as bootstrap? Just > seems to me that there is no single instance of "remodal" there to require > as it is in jQuery. Is bootstrap getting required the same way? > I am sorry, I just don't quite understand the procedure. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/fk5deO_SszU/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/ee1f281e-473a-4820-9d07-b26cb302692f%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/ee1f281e-473a-4820-9d07-b26cb302692f%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BbPaoKuN%2BD%2BKz7pYijtu9BtUG6CdVqHLAJvyHy%2BcxfeZ46fNg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
