Hi, The approach looks good to me. We really have much plugins, which may benefit from the Build Selector functionality. If required, I could create a clone of the plugin directly in the jenkinsci organization and make you both plugin developers.
>From the terminology perspective, maybe makes sense to use "RunSelector" instead of the "BuildSelector". It's not so important, but maybe it's a good opportunity to align it. Best regards, Oleg 2016-07-06 1:16 GMT+02:00 Ikedam <de...@ikedam.jp>: > Hello, Alex. > > > What do you think about the idea of moving the *BuildSelector* > extension point to a separate plugin repository? > > Sounds good to me. > As you pointed, the build selection feature of CopyArtifact is also useful > for other plugins. > > Though CopyArtifact 2.0 is still in progress (for long time...), I belive > we should base on CopyArtifact 2.0: > > * It outputs diagnostic messages. > * It works with `BuildFilter`, which enables us to specify more > complicated conditions to pick builds. > * Copying features are completely isolated from BuildSelectors. > > We can start in a following way: > > * Clone jenkinsci/copyartifact-plugin into ikedam/build-selector-plugin > (or alexsomain/build-selector-plugin) > * Merge copyartifact-2.0. (#71) > * Rename packages and classes, and remove deprecated features. > * Ask to fork it to jenkinsci/build-selector-plugin > * Release build-selector-plugin 0.1.0. > > Some issues: > > * CopyArtifactPermissionProperty. I think it shouldn't moved to > build-selector-plugin and build-selector-plugin should provide an alternate > mechanism. > > Regards, > ikedam > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCeaZXwbzQ6AB9HYSSESDAhq2EDgKQNvjDtweOUDv3cgg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
