On Wed, Aug 10, 2016 at 10:54 AM, Stephen Connolly <[email protected]> wrote: > Can result in writing an invalid byte sequence in the properties UTF blob... > which then on the server side can result in a corrupted Properties load and > the challenge will fail...
Under what circumstances would there be a non-ASCII string being encoded here? Localized agent name? I would suggest just changing the code to use UTF-8 everywhere (you can ask `Properties` to be loaded with an encoding of your choice); or else use ISO-8859-1 for the places where a `Properties` is being passed back and forth. Only a compatibility issue for the unlikely event of someone with a non-ASCII agent name who is using an older `slave.jar` with a newer server or vice-versa (though from the sound of it this did not work to begin with so nothing is lost). -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr14NH3CkHQiQw_7sNPR0FQYro%2BwWFmuZ-NQ0SuSrcBRyw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
