Hi, So we have at least 4 +1s in all PRs + a kind of "the approach looks good to me " from orrc in IRC. I think it's enough to proceed taking the current community ratings into account (2 positive vs. 9 negative).
Kohsuke is available to spin the release, and I think it's better to do it sooner than later. BR, Oleg понедельник, 7 ноября 2016 г., 21:57:28 UTC+1 пользователь Oleg Nenashev написал: > > So we have all 3 patches ready for review (internal reviewbybees process > have been addressed): > > - https://github.com/jenkinsci/jenkins/pull/2624 > - https://github.com/jenkinsci/jenkins/pull/2622 > - https://github.com/jenkinsci/jenkins/pull/2621 > > Would be great if somebody else reviews them. If we get enough +1s, we may > be probably able to release the fix even today. > > Thanks in advance, > Oleg > > > понедельник, 7 ноября 2016 г., 21:00:24 UTC+1 пользователь Samuel Van Oort > написал: >> >> +1 - needs an out of order release. This causes 2 major breakages. >> >> A small aspect of JENKINS-39404 is responsible for JENKINS-39555, which >> badly breaks the whole pipeline plugin suite (and goodness knows what >> else). >> >> I have a fix for that which works, but am ensuring it doesn't have side >> effects. >> >> On Monday, November 7, 2016 at 1:11:19 PM UTC-5, Oleg Nenashev wrote: >>> >>> Hi, >>> >>> According to my previous experience >>> <https://groups.google.com/forum/#!topic/jenkinsci-dev/53zsNTktxYg>, I >>> assume that nobody in this list cares about the Weekly releases. And you're >>> doing right, LTS is the only way to get enough stability. But I want to try >>> again and to propose out-of-order release (2.30). >>> >>> *Why?* >>> >>> - Many issues opened to JENKINS-39414 >>> <https://issues.jenkins-ci.org/browse/JENKINS-39414>, blocker for >>> any instances having Ruby Runtime >>> - LTS baseline selection is coming >>> - Starting from 2.26 weekly releases are screwed up by regressions >>> - If we do not resolve the fallout, we may have to select 2.25 as >>> the new LTS baseline >>> - In such case major improvements like JNLP4 won't get into the >>> release. >>> - According to Vivek, it's also going to impact the anticipated >>> BlueOcean public release >>> >>> *What to fix?* >>> >>> - JENKINS-39414 <https://issues.jenkins-ci.org/browse/JENKINS-39414> >>> - has not been completely fixed in 2.29 >>> - Stapler needs to be fixed again, PR #2622 >>> <https://github.com/jenkinsci/jenkins/pull/2622> >>> - JENKINS-39465 <https://issues.jenkins-ci.org/browse/JENKINS-39465> >>> - Critical bug, which blocks the JNLP4 adoption >>> - PR #2621 <https://github.com/jenkinsci/jenkins/pull/2621> has >>> two +1s >>> - Not important: Several other minor bugfixes, which could be >>> integrated by tomorrow >>> >>> *When?* >>> >>> - I propose to do it tomorrow (Nov 8) >>> >>> >>> What do you think about it? >>> >>> >>> Best regards, >>> Oleg >>> >> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/90974857-f373-46d2-9e33-6a4d851217e1%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
