(replies inline) On Mon, Feb 6, 2017 at 10:11 AM R. Tyler Croy <[email protected]> wrote:
> (replies inline) > > On Sun, 05 Feb 2017, Slide wrote: > > > I won't be at the hackathon, but I'll take a look. Some of the tests were > > written without any windows considerations taken into account, so the > > sooner we can get this fixed (so people who write new tests get feedback > on > > windows being broken by them) the better. > > Is there a compelling reason not to just mark all these failing tests as > skipped on the Windows platform and move on? > Well, from what I can see, several of the tests are just newline issues, people expect \n only, when on Windows it should be \r\n. I don't think we should skip tests for just that reason, we should fix as many of the tests as possible so that we have as good of coverage on Windows as on Linux. Just skipping them seems too hacky to me. > > - R. Tyler Croy > > ------------------------------------------------------ > Code: <https://github.com/rtyler> > Chatter: <https://twitter.com/agentdero> > xmpp: [email protected] > > % gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F > ------------------------------------------------------ > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/20170206171055.GU26439%40blackberry.coupleofllamas.com > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVfmJ0CzKKQ09Su%3D1dYQirW8xvzMq1rP-v%2BCY2vBPa0d7g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
