Hi, Am Sonntag, 12. März 2017 16:32:22 UTC+1 schrieb Stephen Connolly: > > I do not think this is the right way to go at all. > Would you also implement the SCMSourceNavigator for GitLab within the GitHub Branch Source Plugin just as their names are similar? Bitbucket Cloud and Bitbucket Server are 2 different products so IMHO they should be handled by different plugins. Although Bitbucket Cloud and Bitbucket Server are both developed by Atlassian they don't even share the same code base. IIRC Bitbucket Cloud is written in Python whereas Bitbucket Server is written in Java. They have different APIs to interact with them so I can't see any good reason why they should be handled by a single plugin. IMHO the current solution doesn't follow the idea of a pluggable system.
> > There is a refactoring or two from my PoV to take place in the current > plugin and that will result in much cleaner code without fracturing things. > > While there are multiple webhook plugins available for BB server, from my > understanding there is only one that has the events required to give > efficient event notification for scm api (and I had to write the patch to > get that too!) > This is wrong. Most of the WebHook addons I saw provide the necessary information to give efficient event notification for the scm api. Additionally not everybody has the chance to install exactly the add-on that is supported by the Bitbucket Branch Source Plugin. Depending on the amount of users that have access to a Bitbucket Server you have to setup some policies for add-on installations to not slow down the whole server by installing each and every add-on. Btw. this is the case in the company where I work. Regards, Robin -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1ee88bbb-14aa-4a02-9687-14651b6b284c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
