Thanks for doing it. When I was trying the plugin, it also was a serious issue in my case. I have added several comments to the pull-request.
Best regards, Oleg воскресенье, 26 марта 2017 г., 11:49:07 UTC+2 пользователь Christian McHugh написал: > > That was helpful to get started. Based on that (and many github searches > for examples) I have a branch which seems to do the job: > https://github.com/jenkinsci/saltstack-plugin/pull/62 > > This plugin really comes down to parsing the jenkins form, sends off an > http request, and then parses the response for errors. I've wrapped the > http request section in a channel.call, as that is the bit that needs to be > localized to the agent in the case of hostname or firewall rules. > > If anyone is able to review, I'd love to get feedback. > > Thanks all! > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bb075aec-942e-4493-a0f0-bf76ea94f57c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
