Stephen has shot down my previous proposals to switch to using SLF4J before
because of the SLF4J -> JUL bridge has terrible overhead in performance. So
if we were to switch to SLF4J we also need to switch the default logging
backend because otherwise we would really have a performance issue even if
we didn't have one before.
But I'm finding it hard to grasp how we would do this. configuring JUL is
hard as it is, and if core and only a few plugins swtches admins would have
an even bigger headache in having to maintain two logging configs, one for
what we switch to and one for JUL for the plugins that haven't updated yet.
/B
On Wed, Apr 12, 2017 at 2:27 PM, Baptiste Mathus <m...@batmat.net> wrote:
> I'm somehow +0.9 for moving away from JUL, and -0.5 to move to anything
> else than the SLF4J facade (pleonasm). The API is easy to use and we can
> delay or switch to another impl without touching the code.
>
> I am not that convinced that apart from rare cases where people enabled
> more logging for debugging purpose, logging would really be the bottleneck
> for perf in 99%, but like Cyrille I think it's more the clunkiness of the
> JUL API that would justify the work, for more developer-pleasure for the
> codebase. And more attractivity for contributors globally.
>
> Because, well:
>
> if (LOGGER.isLoggable(Level.FINE)) {
>
> LogRecord lr = new LogRecord(Level.FINE, "{0} WUT");
> lr.setThrown(e);
> lr.setParameters(new Object[]{name});
> logger.log(lr);
>
> }
>
> could then be replaced by:
>
> LOGGER.trace( "{0} WUT", name, e);
>
> Also, SLF4J offers many *-over-slf4j shims to redirect existing API usages
> to the same pipe, which is likely to be very useful for our purpose. (maybe
> others do so too, though, didn't check)
>
>
> 2017-04-12 12:25 GMT+02:00 Cyrille Le Clerc <clecl...@cloudbees.com>:
>
>> I prefer the SLF4J syntax to the java.util.logging syntax, I don't like
>> at all the java.util.logging syntax.
>>
>> I think that using a friendly logging API is a good reason to move away
>> from java.util.logging.
>>
>> Cyrille
>>
>> On Tuesday, April 11, 2017 at 4:25:10 PM UTC+2, Jesse Glick wrote:
>>>
>>> On Tue, Apr 11, 2017 at 9:14 AM, Stephen Connolly
>>> <stephen.al...@gmail.com> wrote:
>>> > Java Utils Logging is horrible in terms of performance.
>>>
>>> All I see from a quick read is that unbuffered handlers are a problem
>>> if you are in fact logging tons of messages. In normal operation
>>> Jenkins does _not_ logs tons of messages—unless you have set up a
>>> `FINE` logger in `support-core`, but that has its own handlers, which
>>> we can trivially buffer if they are not already.
>>>
>>> So why would we waste precious developer time, and risk
>>> incompatibilities? Is there some actual significant performance issue
>>> *in Jenkins* (not a microbenchmark) that you are trying to fix?
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/f35899a9-a74b-4442-9b0b-06cb5646a99a%40googlegroups.com
>> <https://groups.google.com/d/msgid/jenkinsci-dev/f35899a9-a74b-4442-9b0b-06cb5646a99a%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CANWgJS5taen55KuwSJhcEKLBbmqDq4-zoqgTOKGvji%3Dm0errXw%
> 40mail.gmail.com
> <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5taen55KuwSJhcEKLBbmqDq4-zoqgTOKGvji%3Dm0errXw%40mail.gmail.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>
--
Robert Sandell
*Software Engineer*
*CloudBees Inc.*
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0La56%2BF%2B0yRPXBSU2W%3DeqacD7QPAMoAU4jKZPgBkRbuQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
