Hello Jesse,

thank you again for your tips. I have made an update of the code [1] 
<https://github.com/dice-project/DICE-Jenkins-Plugin/commit/e5f249b151b79c44a60e13b782eb56c81c1a4f8d>
 
according to my understanding of your comments. Note that I implemented `
RunAction2` methods on both Action classes just to see what happens. 
However, these changes alone do not resolve my problem: the project action 
does not get invoked by Jenkins - I do not see any visualizations 
implemented in the plug-in, and I get `No matching rule was found on 
<org.jenkinsci.plugins.workflow.job.WorkflowJob@7be09d78[DiceTestPipeline]> 
for "/dice-dashboard"`.

I have created a pull request [2] 
<https://github.com/matejart/DICE-Jenkins-Plugin/pull/1> where hopefully it 
will be easier to comment the changes and the code.

Thank you and best regards,
Matej

[1] 
https://github.com/dice-project/DICE-Jenkins-Plugin/commit/e5f249b151b79c44a60e13b782eb56c81c1a4f8d
[2] https://github.com/matejart/DICE-Jenkins-Plugin/pull/1

Dne sreda, 21. junij 2017 17.03.37 UTC+2 je oseba Jesse Glick napisala:
>
> On Wed, Jun 21, 2017 at 3:20 AM, Matej Artač <[email protected] 
> <javascript:>> wrote: 
> >> Either attach all the `Actions` at top level (`Run.addAction`), or make 
> >> the nested structures extend `Object` and implement `RunAction2` on the 
> >> actual single `Action`. 
> > 
> > By the actual single Action you mean the Build action? What is 
> considered 
> > here as a top level? Won't extending Object remove the ability to show 
> icons 
> > on the appropriate level? 
>
> Yes, so if you are using all the actions as actual `Action`s then you 
> need to attach them all to the build, using `Run.addAction` on each. 
> And then get rid of the field in one action holding a list of other 
> actions. 
>
> It is hard to discuss details of mistakes in your code over a mailing 
> list. Much better to propose changes via pull request and then request 
> reviewers, where individual lines can be annotated. 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/500bd463-1fa3-4705-8183-f5a739d7a175%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to