>
> Make the common parts into a `Describable` with a `config.jelly`. 
> Include those into the `Builder` and the `Publisher` as a field bound 
> to `f:property`. Then the `Publisher`’s `config.jelly` would simply 
> have another entry with an `f:checkbox`. 
>

That makes sense! That would mean changing the interface, but it seems 
warranted in this case.
I guess to make it backward compatible I could still keep the old field, 
forward the setting from the Publisher and pass in a hardcoded value from 
the Builder.


> (Or, again IMO, do not clutter the plugin with options like this. A 
> `Publisher` designed for freestyle projects should just not run when a 
> build is unstable—good enough. Declarative Pipeline users, when 
> consuming a `Builder & SimpleBuildStep`, have straightforward detailed 
> control over such behaviors using `when` blocks.) 
>

The plugin does seem a bit over-engineered, but that's the way I inherited 
it.
If I want my changes to be backward compatible, I assumed I have to keep 
them.

Do you know, apart from the overall download count, if there is any way to 
check if features are being used?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/52f66aee-ba13-4766-874d-c717fb23d2b4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to