Yes this is a good short terms workaround. I'm looking if stapler can easily answer "does this descriptor have a global view" without making assumption on the view template language, but I think your fix is ok for now, please push it to main repository
2017-11-24 14:07 GMT+01:00 Ewelina Wilkosz <[email protected]>: > when I changed > > URL global = ConfigurationAsCode.class.getClassLoader().getResource( > cl+"/global.jelly"); > to > > URL global = descriptor.getKlass().toJavaClass().getClassLoader() > .getResource(cl+"/global.jelly"); > it started working for me... > > On Friday, November 24, 2017 at 1:54:10 PM UTC+1, nicolas de loof wrote: >> >> You're right, that was a distinct (non blocking) issue. >> >> this global.jelly lookup was working for me as I had mailer plugin >> declared as a dependency and ran mvn hpi:run for testing, so this lib is in >> core classpath >> will need to investigate a better way to check a Descriptor has a >> global.jelly view (I'm so pleased to dig into Stapler internals :P) >> >> >> >> 2017-11-24 13:34 GMT+01:00 Ewelina Wilkosz <[email protected]>: >> >>> It looks the list is not empty, it's URL global = ConfigurationAsCode. >>> class.getClassLoader().getResource(cl+"/global.jelly"); that returns >>> null, is it the same issue you're talking about? >>> >>> On Friday, November 24, 2017 at 10:19:19 AM UTC+1, nicolas de loof wrote: >>>> >>>> yes indeed, for a reason I don't understand yet, >>>> "Jenkins.getInstance().getExtensionList(Descriptor.class)" returns an >>>> empty list :-\ >>>> investigating ... >>>> >>>> 2017-11-24 9:51 GMT+01:00 Ewelina Wilkosz <[email protected]>: >>>> >>>>> Hi Nicolas, I have a problem with configuring mailer >>>>> - if I use "mailer:" as root element Jenkins won't start - exact copy >>>>> from demo folder >>>>> - if I put mailer under "jenkins:" root element there is no error on >>>>> startup but no configuration is applied >>>>> >>>>> Is there anything special about that one, that should maybe be >>>>> mentioned in the documentation? >>>>> >>>>> >>>>> >>>>> On Thursday, November 23, 2017 at 3:27:19 PM UTC+1, nicolas de loof >>>>> wrote: >>>>>> >>>>>> I wrote this documentation >>>>>> <https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/PLUGINS.md> >>>>>> for >>>>>> plugin developers to understand the required changes so we can support >>>>>> Descriptor as configuration-as-code targets. >>>>>> I'll work on writing some pull-requests applying this approach to >>>>>> some major plugins. >>>>>> >>>>>> 2017-11-15 16:27 GMT+01:00 nicolas de loof <[email protected]>: >>>>>> >>>>>>> this is really work in progress, i.e not even tested on my own >>>>>>> before I propose this in a PR :P >>>>>>> was just for information that I was looking into implementing a fix >>>>>>> for this idea >>>>>>> >>>>>>> 2017-11-15 16:24 GMT+01:00 Jesse Glick <[email protected]>: >>>>>>> >>>>>>>> On Wed, Nov 15, 2017 at 9:51 AM, nicolas de loof >>>>>>>> <[email protected]> wrote: >>>>>>>> > proposed improvement to Descriptor.configure (WiP) : >>>>>>>> > https://github.com/ndeloof/jenkins/tree/JENKINS-48018 >>>>>>>> >>>>>>>> If you are soliciting feedback, just file as a PR and mark as >>>>>>>> `work-in-progress`. Easier to gather comments that way. >>>>>>>> >>>>>>>> -- >>>>>>>> You received this message because you are subscribed to the Google >>>>>>>> Groups "Jenkins Developers" group. >>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>> send an email to [email protected]. >>>>>>>> To view this discussion on the web visit >>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0%2Bd >>>>>>>> %2BE1RO8PTVeUHnpvH3367zd6D%2Bwa2%2BAeSTgTd9Zc4Q%40mail.gmail.com. >>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>> >>>>>>> >>>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/99138212-72c >>>>> f-47e8-b002-8e00974e1c44%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/99138212-72cf-47e8-b002-8e00974e1c44%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit https://groups.google.com/d/ms >>> gid/jenkinsci-dev/eb597cea-7a8e-43ec-a311-42bc44a80c7b%40goo >>> glegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/eb597cea-7a8e-43ec-a311-42bc44a80c7b%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/jenkinsci-dev/8f73dced-21c7-4d43-8f55-f41da66c8ea0% > 40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/8f73dced-21c7-4d43-8f55-f41da66c8ea0%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzmakRpAXKFXJo8ojvGdKCm8y_Nx3ytL6VQFMDiSr7Dg%2BA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
