Hello,

While the Recorder, then Notifier order is documented in the documentation:

   - http://javadoc.jenkins-ci.org/hudson/tasks/Recorder.html
   - http://javadoc.jenkins-ci.org/hudson/tasks/Notifier.html
   - http://javadoc.jenkins-ci.org/hudson/model/Build.html
   
, it seems not to be enforced by Jenkins.

https://issues.jenkins-ci.org/browse/JENKINS-37299 is a reproducer of the 
issue. For the anecdote, kohsuke did the 
33df3bc7602e46fdbedb4966302d6dae06fe5b1e 
<https://github.com/jenkinsci/claim-plugin/commit/33df3bc7602e46fdbedb4966302d6dae06fe5b1e>change
 
to the claim plugin to fix 
http://jenkins-ci.361315.n4.nabble.com/claim-plugin-text-finder-plugin-conflict-td385850.html#none
 (up-to-date 
url matching the one in the commit message) 8 years ago, which is the exact 
same issue reported in this ticket.

kohsuke introduced the Recorder/Notifier distinction in Jenkins core change 
b63f162f75964f52118755105bee676d29da8828 
<https://github.com/jenkinsci/jenkins/commit/b63f162f75964f52118755105bee676d29da8828>
.
IIUC, this change has some order-enforcement mechanism via the order of 
publishers in the job ui, through the Publisher.DescriptorExtensionListImpl 
<https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/tasks/Publisher.java#L130>,
 
which sorts the publishers according to their types.
This behavior can still be seen in Jenkins job configuration ui, where the 
potential publishers list is sorted by types, and where adding one in the 
jobs adds in at the same position that the one it has in the list of 
potential publishers.
I failed to find any other mecanism taking care of this order in the rest 
of the code.

While this was probably enough at some point, now that we can reorder steps 
by drag & dropping, and that we can do declarative pipelines, I think it is 
void today.

Is this issue already known from core team ? Are there any plans that will 
make it void for the future, or is it something that needs to be fixed?

Arnaud






-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/e8e41a50-d2b7-4535-8e44-d49491184ae3%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to