LGTM.

Same concern/request as Jesse, but ack that it will be processed
separately, makes sense.

2018-02-19 17:44 GMT+01:00 Daniel Beck <m...@beckweb.net>:

>
> > On 19. Feb 2018, at 15:57, Jesse Glick <jgl...@cloudbees.com> wrote:
> >
> > Would org membership allow people to be requested as reviewers on pull
> requests to repositories to which they lack write permission, which
> currently is the only workaround for this missing GitHub feature?
>
> No, that requires them to be 'collaborators' of the specific repo. it's
> enough to be explicitly granted read access to a repo to be a collaborator
> (for example via a team). I plan to discuss ideas about that separately,
> it's out of scope for this particular JEP.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/4B71344F-D4E6-4506-BBFF-13F86357BFAE%40beckweb.net.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS52wfwTkWW%3DK7QWKRUequOi%2BaGz72kPAHH84kcFFPjagQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to