Created: https://github.com/jenkinsci/cmakebuilder-plugin/pull/8 implementing SimpleBuildStep is the easiest and fastest way to get going :)
The main reason why SimpleBuildStep is wonderful: https://github.com/jenkinsci/jenkins/blob/11c81cacf5776415cd68ee26f32e5d28549a0322/core/src/main/java/hudson/tasks/BuildStepCompatibilityLayer.java#L63-L82 https://github.com/jenkinsci/jenkins/blob/11c81cacf5776415cd68ee26f32e5d28549a0322/core/src/main/java/hudson/tasks/BuildStepCompatibilityLayer.java#L63-L82 https://github.com/jenkinsci/jenkins/blob/11c81cacf5776415cd68ee26f32e5d28549a0322/core/src/main/java/hudson/tasks/BuildStepCompatibilityLayer.java#L63-L82 Den tirsdag den 20. marts 2018 kl. 23.06.39 UTC+1 skrev Joseph P: > > Your implementation of a separate step and using workflow plugin seems > overkill to support pipeline. > > All you need is for your builder to implement SimpleBuildStep and provide > the descriptor with a simple > > /Joseph > > Den tirsdag den 20. marts 2018 kl. 21.00.49 UTC+1 skrev Martin Weber: >> >> To implement pipeline compatibility for the cmakebuilder plugin[1], I >> changed >> the required jenkins version from 1.580.3 to 1.643.3. >> Parent pom version is 2.7. >> >> With 1.643.3, my form-round-trip tests [2] fail with 'internal server >> error'. >> I also ran the test from eclipse, which gave me some more output in the >> console: >> >> INFO: Started @11170ms >> === Starting >> checkValidation(hudson.plugins.cmake.CmakeBuilderFormRoundTripTest) >> Mar 20, 2018 8:54:55 PM hudson.ExpressionFactory2$JexlExpression evaluate >> WARNING: Caught exception evaluating: i.descriptor in /jenkins/job/test0/ >> configure. Reason: java.lang.reflect.InvocationTargetException >> java.lang.reflect.InvocationTargetException >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >> >> >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java: >> >> >> 43) >> at java.lang.reflect.Method.invoke(Method.java:606) >> at >> org.apache.commons.jexl.util.PropertyExecutor.execute(PropertyExecutor.java: >> >> 125) >> ... >> at java.lang.Thread.run(Thread.java:748) >> Caused by: java.lang.AssertionError: class >> hudson.plugins.cmake.CmakeBuilder >> is missing its descriptor >> at jenkins.model.Jenkins.getDescriptorOrDie(Jenkins.java:1223) >> at hudson.tasks.Builder.getDescriptor(Builder.java:67) >> at >> hudson.plugins.cmake.CmakeBuilder.getDescriptor(CmakeBuilder.java:395) >> >> >> Can someone please explain whats going wrong/different with 1.643.3 and >> give >> me some hints how to fix the test? >> >> TIA, >> Martin >> >> [1] https://github.com/jenkinsci/cmakebuilder-plugin >> [2] <https://github.com/jenkinsci/cmakebuilder-plugin/blob/ >> 994787a44529895ba4af766f5b5d7491339fb417/src/test/java/hudson/plugins/cmake/ >> >> CmakeBuilderFormRoundTripTest.java#L21 >> <https://github.com/jenkinsci/cmakebuilder-plugin/blob/994787a44529895ba4af766f5b5d7491339fb417/src/test/java/hudson/plugins/cmake/CmakeBuilderFormRoundTripTest.java#L21>< >> >> >> -- >> E-Mails sollten Text sein, Text und nur Text. >> Wenn Gott gewollt hätte, dass E-Mails in HTML geschrieben würden, >> endeten Gebete traditionell mit </amen>. >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3bca97f1-6875-4d9b-80e6-87b3c7b1e9fc%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
