*>This is a sign that your zip operation is uninterruptible, which is >
potentially a problem, though perhaps not your first priority for bug >
fixing.*
I'm totally ok if it's not interruptible. It's a 3rd party lib and you
can't expect all libs to work perfectly.
But it should interrupt after zip operation finishes, no?
So it should just be delayed a little which is totally ok.
I've check all the code from the zip library I use (org.zeroturnaround.zip)
and they don't seem to be doing anything with Interrupted expecting that
would case this behaviour.
Also If I run my plugin just on master (so not inside a
MasterToSlaveCallable) it does get interrupted ok (not instantly but as
soon as zip operation is finished and without errors).
So my understanding is that maybe something in how MasterToSlaveCallables
are handled cause this strange behaviour since on master and on pipelines
works ok and the problem
seems to be just for MasterToSlaveCallables.
I even wrapped all my zipping code in a try {} catch (Exception e) {} and
nothing is thrown by the zip code.
*> Well, `ArtifactArchiver` in core does something conceptually similar, *
*> for example. *
I've checked this and the code there is kind of split into multiple client
to master operations plus it doesn't use any 3rd party library.
It first makes a call `FilePath.act(` to get the list of files. And then it
calls .archive on them.
Everything seems to be handled with just calls to FilePath methods so just
native internal Jenkins APIs
On Friday, March 23, 2018 at 9:37:41 PM UTC+2, Jesse Glick wrote:
>
> On Fri, Mar 23, 2018 at 3:21 PM, Daniel Anechitoaie
> <[email protected] <javascript:>> wrote:
> > If it happens and it's while a long running process (like zipping a big
> > folder) it even asks me after a while if I want to force close the job
> which
> > also works.
>
> This is a sign that your zip operation is uninterruptible, which is
> potentially a problem, though perhaps not your first priority for bug
> fixing.
>
> > I did searched for other plugins that implement a build step and that
> > actually try to do any kind of file processing inside those builds
>
> Well, `ArtifactArchiver` in core does something conceptually similar,
> for example.
>
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/5a7386f4-fb06-49d6-bc9e-d500dd576042%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
