Sorry for being late to this... I agree with the proposed approach, the only thing that concerns me is that it seems you need to build the custom war locally so is installed on your local repo, now what happens with CI jobs that execute the PCT in parallel? All of them would need to locally build the war file or share the local maven repo or something similar... So I would say that adding the ability to set the location of the file to be loaded by `WarExploder` is going to be a real need if we want this to be in production
Regards, Raul On Tuesday, March 27, 2018 at 4:12:05 PM UTC+2, Oleg Nenashev wrote: > > I have published the current state of the project as 0.1-alpha-2. So Maven > flow > <https://github.com/jenkinsci/custom-war-packager/blob/master/demo/all-latest-core-maven/pom.xml> > > can be also used now. Since it is an alpha version, there may be > incompatible changes later. But any feedback will be appreciated. If you > see any defects or need any changes, please submit tickets in the GitHub > issue tracker. <https://github.com/jenkinsci/custom-war-packager/issues> > I will move to JIRA once it reaches a stable state. > > So far I am going to proceed with the better demo for CI flows with Custom > WAR Packager. > > Best regards, > Oleg > > On Friday, March 23, 2018 at 4:18:57 PM UTC+1, Jesse Glick wrote: >> >> On Thu, Mar 22, 2018 at 8:19 PM, Oleg Nenashev <[email protected]> >> wrote: >> >> We could introduce a new system property or environment variable >> pointing >> >> to a custom WAR file >> >> path for `WarExploder` to use, perhaps. >> > >> > It would require plugins to update to the recent JTH, but it's not a >> problem >> > since we can always pass Maven property when running builds in CI/PCT. >> >> I think it is fine to say that if you want this to work from your >> plugin’s tests, it just needs to have a sufficiently new POM. That is >> something we can require for Essentials plugins at least. >> >> >> The actual test runs will go back to the local Maven >> >> repository for a `jenkins-war` artifact with the specified version >> number >> > >> > It is fine with me, because Custom War Packager installs artifacts to >> the >> > local repo anyway. >> > Obviously there are some limitations on groupId and artifactId to make >> such >> > approach running, but it works. >> >> Good enough! Just please use `SNAPSHOT`-labelled versions so cron jobs >> like >> >> find -L ~/.m2/repository \( -type d -name '*-SNAPSHOT' -prune -o -type >> f -name maven-metadata-local.xml \) -exec rm -rf {} \; >> >> can clean up. >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/21c59a4e-9f92-4b27-934a-fbbb5e396bdb%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
