Seems reasonable. The implementation separates JSON records with a newline. This is not apparent from the JEP; it would be nice to mention it, so that readers do not wonder whether you are using some kind of streaming JSON parser (which is unnecessary when each line is a well-formed JSON document).
`JsonFormatter.formatException` can be replaced with `Functions.printThrowable`, which formats chained exceptions more readably. The JEP proposal for a future `stacktrace` field neglects to mention that this will not work as is for exceptions with causes and/or suppressed exceptions. In general `Throwable.printStackTrace` can be overridden in nontrivial ways, sometimes including information not present in the `message` nor stack trace (though less so after JENKINS-46140), so I would not recommend bothering with anything but a plain printed string. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1mbH2e86BymBfSBcxu4%2BhM0TewBS7XyBreok8AFg9yOA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
