Based on the fact custom-war-packager already support KK's approach I'm asking jenkinsci organisation owners to DELETE the jenkinsci/jenkinsfile-runner repository, and fork https://github.com/kohsuke/jenkinsfile-runner as a replacement.
My own version (https://github.com/ndeloof/jenkinsfile-runner) will stay there for those interested in trying to reconcile both. Le jeudi 6 septembre 2018 17:10:52 UTC+2, Liam Newman a écrit : > > Oleg, > +1 for cleanup, definitely. The path you propose overall sounds good to > me. > > On Thursday, September 6, 2018 at 6:40:23 AM UTC-7, Oleg Nenashev wrote: >> >> Obviously, step (5) is a bad idea then. Could we just have 2 repos >> without "fork" relations then? >> If the codebase is not shared, it would help. >> >> As you can guess I have my strong opinion about classloader voodoo in >>> KK's approach to a jenkinsfile-runner CLI. >>> >> Fine for PoC IMHO. It improves performance, and it may be useful in cases >> when we want to have fast builds with really short initialization times. I >> was doing some performance hacks for similar purposes a while ago (actually >> some even weirder hacks). Obviously, a final implementation should not be >> based on Jenkins Test Harness and JenkinsRule, some Jenkins core patches >> will likely be needed. >> >> >> On Thu, Sep 6, 2018 at 3:31 PM nicolas de loof <[email protected]> >> wrote: >> >>> please note ndeloof/jenkinsfile-runner is a complete different design vs >>> KK initial prototype >>> they don't share architecture nor git history (only few java classes) >>> >>> so you'll have to choose one approach over the other >>> >>> As you can guess I have my strong opinion about classloader voodoo in >>> KK's approach to a jenkinsfile-runner CLI. >>> >>> Le jeu. 6 sept. 2018 à 15:27, Baptiste Mathus <[email protected]> a >>> écrit : >>> >>>> +1 for cleaning up. Like we recommend for plugins, it would be nice >>>> that canonical repo location is more clearly the one under jenkinsci org >>>> >>>> Le jeu. 6 sept. 2018 à 15:24, Oleg Nenashev <[email protected]> a >>>> écrit : >>>> >>>>> Hi all, >>>>> >>>>> It seems we have a splitbrain issue in this project. >>>>> Currently there is the following fork tree: >>>>> >>>>> - https://github.com/kohsuke/jenkinsfile-runner >>>>> - https://github.com/ndeloof/jenkinsfile-runner >>>>> - https://github.com/jenkinsci/jenkinsfile-runner >>>>> >>>>> Jenkinsfile Runner in Kohsuke's repo has the most number of stars + >>>>> there is a number of issues and pull requests. It makes the jenkinsci >>>>> repo >>>>> unsearchable, and it can also confuse users looking for a place to report >>>>> issues / propose patches. >>>>> >>>>> I propose to do the following: >>>>> >>>>> 1. Remove https://github.com/jenkinsci/jenkinsfile-runner and >>>>> evacute the branches somewhere >>>>> 2. Move https://github.com/kohsuke/jenkinsfile-runner to jenkinsci >>>>> org (yes, move, not fork) >>>>> 3. Rename the current master branch to "kohsuke-master" >>>>> 4. Reintegrate the current >>>>> https://github.com/jenkinsci/jenkinsfile-runner state as a master >>>>> branch >>>>> 5. See if "master" and "kohsuke-master" can be merged >>>>> >>>>> WDYT? >>>>> >>>>> BR, Oleg >>>>> >>>>> On Wednesday, April 4, 2018 at 9:30:15 PM UTC+2, Kohsuke Kawaguchi >>>>> wrote: >>>>>> >>>>>> Ouch, that's a shame. It looked like an interesting project, I hope >>>>>> my writing to you didn't trigger that. >>>>>> >>>>>> You say "stress builds and also to burn in our build agents" -- can >>>>>> you elaborate on that? It sounds like you are trying to warm up a cache >>>>>> or >>>>>> something, but I'm not sure what that means in the context of builds. >>>>>> >>>>>> On Wed, Apr 4, 2018 at 11:15 AM Tom Shaw <[email protected]> wrote: >>>>>> >>>>>>> Hi Kohsuke, >>>>>>> >>>>>>> Thanks for getting in touch. I've had to remove that repo >>>>>>> temporarily at the request of my former employer. It looks like we are >>>>>>> trying to solve the same problem. I wanted to use jenkinless to stress >>>>>>> builds and also to burn in our build agents. It's more of a convenience >>>>>>> tool. Running the slave using docker in docker worked really well. I >>>>>>> might >>>>>>> try and turn this into an executable that can be stored in the repo >>>>>>> alongside code. >>>>>>> >>>>>>> Tom >>>>>>> >>>>>>> >>>>>>> On Wed, 4 Apr 2018, 00:19 Kohsuke Kawaguchi, <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi, Thomas, >>>>>>>> >>>>>>>> Tyler passed me a link to your project >>>>>>>> https://github.com/tomwillfixit/jenkinless, which is in a similar >>>>>>>> space with my project of the day called Jenkinsfile Runner. >>>>>>>> >>>>>>>> I haven't studied your project carefully yet, but I already see >>>>>>>> some interesting ingredients like memcached that I have no idea what >>>>>>>> you >>>>>>>> use it for :-) I'd love to hear from you the philosophy & use cases >>>>>>>> that >>>>>>>> led to it. And I'd also love to hear what you think of Jenkinsfile >>>>>>>> Runner. >>>>>>>> I think we have similar interests here, are there any opportunity to >>>>>>>> collaborate? >>>>>>>> >>>>>>>> On Thu, Mar 1, 2018 at 11:23 AM Kohsuke Kawaguchi <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> And of course I forgot to have the link to the project! >>>>>>>>> https://github.com/kohsuke/jenkinsfile-runner >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Mar 1, 2018 at 11:22 AM Kohsuke Kawaguchi < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Jenkinsfile Runner is an experiment to package Jenkins pipeline >>>>>>>>>> execution as a command line tool. The intend use cases include: >>>>>>>>>> >>>>>>>>>> - Use Jenkins in Function-as-a-Service context >>>>>>>>>> - Assist editing Jenkinsfile locally >>>>>>>>>> - Integration test shared libraries >>>>>>>>>> >>>>>>>>>> Over the past year, I've done some deep-dive 1:1 conversations >>>>>>>>>> with some Jenkins users and I felt something like this might move >>>>>>>>>> the >>>>>>>>>> needle for them in an important way. >>>>>>>>>> >>>>>>>>>> I'd love to hear any reactions on your side. Could something like >>>>>>>>>> this be important for you, does it miss any key points for you? If >>>>>>>>>> you >>>>>>>>>> mentally picture a perfect version of this, what would that do, and >>>>>>>>>> how >>>>>>>>>> would you use? >>>>>>>>>> >>>>>>>>>> Let me know! >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Kohsuke Kawaguchi >>>>>>>>>> >>>>>>>>> -- >>>>>>>>> Kohsuke Kawaguchi >>>>>>>>> >>>>>>>> -- >>>>>>>> Kohsuke Kawaguchi >>>>>>>> >>>>>>> -- >>>>>> Kohsuke Kawaguchi >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/452ee425-972d-4563-920e-cbb6644bacab%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/452ee425-972d-4563-920e-cbb6644bacab%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5B1k5w5HYLGYugQz1mOBg1%2BesYqp0Ccok1Z_Esh%2BYeJg%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5B1k5w5HYLGYugQz1mOBg1%2BesYqp0Ccok1Z_Esh%2BYeJg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> -- >>> Nicolas De Loof >>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Jenkins Developers" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/jenkinsci-dev/gjz3CDhi-kk/unsubscribe. >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzkPHTfhQT8Xp7qTGbTttLpVdjYQY%3DV0LAMVn6px5mk5AQ%40mail.gmail.com >>> >>> <https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzkPHTfhQT8Xp7qTGbTttLpVdjYQY%3DV0LAMVn6px5mk5AQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0bfbd16e-7f62-4bde-86dd-760a36329140%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
