On Thu, Oct 4, 2018 at 11:21 AM nicolas de loof
<[email protected]> wrote:
> Check implementation of Descriptor#configure(StaplerRequest,JSONObject) in
> your descriptors.
Note that `GlobalConfiguration` subtypes need to override at all.
Arguably that default impl should just be pulled up into `Descriptor`.
> public boolean configure(StaplerRequest req, JSONObject json) throws
> FormException {
> req.bindJSON(this, json);
> save();
Normally the `save()` call should be within the setter, not here. If
you wish to avoid repeated saves in close succession, that is what
`BulkChange` is for. (Should probably be used from within the standard
impl.)
> @DataBoundSetter
You should remind readers that they also need corresponding getters.
The Pipeline compatibility guide covers some of the same topics BTW.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3oxch9AzWuHtWh2Zjuk9-o0f9acOmGEyOpL1z%2BD0RwAw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
