I'd suggest you first take inspiration from the Gitea plugin <https://github.com/jenkinsci/gitea-plugin>, last time I checked it had the most clean branch-api implementation. GitHub Branch Source and Bitbucket Branch Source are suffering from a couple of branch-api/scm-api generations of rewrites that can "muddy the waters a bit" when looking at writing a new plugin :)
/B Den sön 19 maj 2019 kl 18:19 skrev Parichay Barpanda < [email protected]>: > Thanks batmat for the answers. > > On Sun 19 May, 2019, 21:27 Baptiste Mathus, <[email protected]> wrote: > >> >> >> Le mer. 15 mai 2019 à 22:17, Parichay Barpanda < >> [email protected]> a écrit : >> >>> Hi all, >>> >>> I was reading the GitHub Branch Source Plugin documentation here - >>> https://go.cloudbees.com/docs/plugins/github-branch-source/ trying to >>> take some inspiration from *GitHub Branch Source Plugin* for a similar >>> *GitLab >>> Branch Source Plugin*. >>> >>> Here are a few questions I would like to ask: >>> >>> 1) An excerpt from the GitHub PR section: >>> >>> “Pull requests will be added to Jenkins as long as the pull request >>> originates from a remote repository, contains a Pipeline script in a >>> Jenkinsfile, and is mergable. >>> *Even when you make changes to your Jenkinsfile, the checked out code is >>> at the revision as the script.*” >>> >>> What does the last line mean? >>> >> >> Not sure TBH. >> >> >>> 2) While running a GitHub folder organisation on my GitHub Account, >>> build log shows the following: >>> >>> “...*19:25:39 GitHub API Usage: Current quota has 51 remaining (2 over >>> budget). Next quota of 60 in 59 min. Sleeping for 6 min 48 sec*.” >>> >>> And the build simply pauses. What is the possible issue here? >>> >> >> Not an issue. More a feature IIUC your question. >> GitHub API has a quota. So if you hammer it too much, your code will >> simply start failing (and it did). >> So like 1 year ago, the code was optimized (thanks Stephen and CloudBees >> sponsoring this) to do less calls and to introduce waits when quota was >> about to be reached. >> >>> >>> 3) Are there any important additions made to the plugin since the >>> documentation was written? A list of classes would also do, I specifically >>> want to look at their codes. >>> I can find some UI changes in behaviours (recent plugin wrt >>> documentation pictures), don't see the folder computation option etc. >>> Looking for any interesting changes which can be leveraged by new Branch >>> Source Plugins? >>> >> >> Not sure for this. I'd recommend you check PRs since then and check how >> much/if docs were added alongside code additions. And don't hesitate to ask >> for clarifications in these merged PRs to be able to possibly file related >> docs PRs. >> >> Thanks! >> >>> >>> Thanks. >>> >>> Regards, >>> Parichay (baymac) >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/d4215d95-55d5-4322-b945-1b272fc512df%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/d4215d95-55d5-4322-b945-1b272fc512df%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6Nvj_%2B_pw-rqS36tgb7JwPcAnKpAQuT9WLDyYwxFyU2Q%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6Nvj_%2B_pw-rqS36tgb7JwPcAnKpAQuT9WLDyYwxFyU2Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAD0DWAN7HaW1VejOExDGNhO4YHG28HmzdvHWBR8OwqN8C60UfA%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAD0DWAN7HaW1VejOExDGNhO4YHG28HmzdvHWBR8OwqN8C60UfA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- *Robert Sandell* Software Engineer CloudBees, Inc. [image: CloudBees-Logo.png] <http://www.cloudbees.com/> E: [email protected] Twitter: robert_sandell -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS0hcQ1Yw8USFCd%2BXEpBRyzFNHH4o-gsXcNZ%2BQEWFGVPYQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
