Awesome Gavin. It was .gitattributes that caused the binary files to change. Thanks.
On Tue, Jul 16, 2019 at 3:47 PM Gavin <[email protected]> wrote: > Oh shot in the dark here. > > > https://github.com/jenkinsci/gitlab-branch-source-plugin/blob/develop/.gitattributes > is set to change the endings of all files. That could potentially mess with > binary files. > > I'm not certain about this but you might need to say your images are > binary. Especially if your committing in windows and the builds that are > failing are in Linux. > > https://help.github.com/en/articles/configuring-git-to-handle-line-endings > > On Tue., Jul. 16, 2019, 3:07 a.m. Gavin, <[email protected]> wrote: > >> Whats the deploy stage? In the jenkins pipeline? In maven? >> >> Have you tried a clean clone of your develop branch. Running mvn clean >> install, then checking git status to see what if anything is generated. >> >> Develop seems to be running properly. >> https://ci.jenkins.io/job/Plugins/job/gitlab-branch-source-plugin/job/develop/ >> the other branches that still have docs/ in them seem to be failing. >> >> Why would you want the webapp directory ignored? As Jessie said, >> everything in your src directory should be your actual files which you want >> committed. >> >> >> >> On Tue., Jul. 16, 2019, 2:43 a.m. Parichay Barpanda, < >> [email protected]> wrote: >> >>> Hi Jesse, >>> >>> I had added the webapp directory to .gitignore to test the build. Now I >>> tried to remove classes that might have affected the images such as >>> GitLabAvatarCache (didn't work), refixed svgs and the pngs (didn't work). >>> The current work can be found in this commit - >>> https://github.com/jenkinsci/gitlab-branch-source-plugin/commit/57c5f1705a78a5a3c6012ebfc0ded91a4c93dcab >>> . >>> >>> I am unable to understand the issue, if it was bug in the code it would >>> have also returned error about the webapp images but it also returns errors >>> with the docs images. >>> >>> On Tuesday, July 16, 2019 at 12:32:01 AM UTC+5:30, Jesse Glick wrote: >>>> >>>> On Sun, Jul 14, 2019 at 11:53 AM Parichay Barpanda >>>> <[email protected]> wrote: >>>> > We can also avoid the error by adding `-Dignore.dirt` flag to Maven >>>> config as was suggested by Marky Jackson. >>>> >>>> No, fix your build process. >>>> >>>> >>>> https://github.com/jenkinsci/gitlab-branch-source-plugin/compare/master...jenkinsci:develop >>>> >>>> is rather suspicious: nothing in `src/` should ever be in `.gitignore`. >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/8e7cc1c9-5298-461c-afd4-4210153eac19%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/8e7cc1c9-5298-461c-afd4-4210153eac19%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dut1bYFsY6j4urdBU1XxFJxJkzkL-rO_YN6w0Eb%2BKiZLFQ%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dut1bYFsY6j4urdBU1XxFJxJkzkL-rO_YN6w0Eb%2BKiZLFQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAD0DWAOW9KEhUMCMAO%3DwHBgh6DCxizkGp9-V2ajszd2puko6jA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
