>
> Oleg, how does this test pass for you (and presumably the CI system that 
> gated this change) with the interactiveBreak invocation intact?
>

I do not run tests locally when integrating changes, I rely on CI.
And CI was green, not sure why.

The issue itself came from https://github.com/jenkinsci/jenkins/pull/3802 , 
and it definitely did not get noticed during code reviews.



 

On Tuesday, August 6, 2019 at 5:49:24 PM UTC+2, Kohsuke Kawaguchi wrote:
>
> I created https://github.com/jenkinsci/jenkins/pull/4142 to get us past 
> this blockage.
>
> On Tue, Aug 6, 2019 at 8:42 AM Kohsuke Kawaguchi <k...@kohsuke.org 
> <javascript:>> wrote:
>
>> Thanks Lloyd. With Surefire 2.20.1, the error message changes more 
>> explicitly to timeout: 
>> https://gist.github.com/kohsuke/4d31b8dbcbfe1926e71ccba08f7f9555
>>
>> The test case in question includes an invocation of 'interactiveBreak', 
>> which is surely wrong? When I remove that line, the test passes.
>>
>> Oleg, how does this test pass for you (and presumably the CI system that 
>> gated this change) with the interactiveBreak invocation intact?
>>
>>
>>
>> On Tue, Aug 6, 2019 at 12:57 AM Lloyd Chang <lloyd...@gmail.com 
>> <javascript:>> wrote:
>>
>>> clarification: the quoted version number "2.20.1" was Surefire, and not 
>>> Jenkins.
>>>
>>> On Tuesday, August 6, 2019 at 12:36:21 AM UTC-7, Lloyd Chang wrote:
>>>>
>>>> > We have it fixed in 2.20.1.
>>>> > https://issues.apache.org/jira/browse/SUREFIRE-1408
>>>>
>>>> On Monday, August 5, 2019 at 11:54:30 PM UTC-7, Oleg Nenashev wrote:
>>>>>
>>>>> I was unable to reproduce it locally on Maven 3.6.0 and Windows.
>>>>> Would it be possible to provide a crashdump?
>>>>>
>>>>> Thanks in advance,
>>>>> Oleg
>>>>>
>>>>>
>>>>> On Tuesday, August 6, 2019 at 6:53:57 AM UTC+2, Kohsuke Kawaguchi 
>>>>> wrote:
>>>>>>
>>>>>> Currently the release of 2.188 is stuck due to a failing 
>>>>>> jenkins.triggers.TriggerTest. The log is 
>>>>>> https://gist.github.com/kohsuke/7ba26b2d9f4a2a49d832610d069d0ab4
>>>>>>
>>>>>> I'll look into this further later, but if anyone has any thoughts on 
>>>>>> what might be wrong, that'd be greatly appreciated.
>>>>>>
>>>>>> -- 
>>>>>> Kohsuke Kawaguchi
>>>>>>
>>>>> -- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to jenkin...@googlegroups.com <javascript:>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/1bd559a1-7c52-4a60-91ad-9c2f97ebe8d5%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/jenkinsci-dev/1bd559a1-7c52-4a60-91ad-9c2f97ebe8d5%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>>
>>
>>
>> -- 
>> Kohsuke Kawaguchi
>>
>
>
> -- 
> Kohsuke Kawaguchi
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5bae9334-db08-4753-b893-c8fb8187ccc2%40googlegroups.com.

Reply via email to