Sorry for the long delay to reply. Yes, I think the message exclusion concept is general purpose enough that our should be a trait on the scm api.
On Mon, Jul 1, 2019, 7:09 AM Chris Kilding <[email protected]> wrote: > Hello, > > The Git plugin has a MessageExclusion extension to skip commits matching > certain message patterns eg ‘[ci-skip]’. I have seen this reimplemented in > a few different places in the Jenkins pipeline stack, and it would make > sense to implement it only once. > > The feature should probably live: > > - At a higher abstraction level (so that all SCM providers and consumers > can use it) > - As close to the checkout as possible (to allow the skip test to be > performed without waiting until after the checkout directive - which is > what the ci-skip-plugin does) > > Would it therefore make sense to move MessageExclusion from the git-plugin > to the scm-api-plugin, together with its related trait? > > (Coincidentally this would deal with > https://issues.jenkins-ci.org/plugins/servlet/mobile#issue/JENKINS-46081) > > Regards, > > Chris > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/12e253d8-9bff-431f-8841-086f1ae5065f%40www.fastmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/12e253d8-9bff-431f-8841-086f1ae5065f%40www.fastmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFKOPp6qNCsLms1%2BQeQzhugfhUP2FKhF_n%2B7ztO7zk2bg%40mail.gmail.com.
