Hi Oleg, 

Thank you for responding. I've responded to some messages on the Pull 
Request and hopefully that does provide some additional clarify on my 
changes. 

In such a case that the changes are deprecating the old functionality of a 
plugin, is it a better practice to publish a new plugin all together. 

I am aware the current state of the plugin should be in use by anyone and 
therefore I am not concerned about impacting users.

On Thursday, October 17, 2019 at 3:27:55 PM UTC-7, Oleg Nenashev wrote:
>
> I am not sure what this pull request does.
> My first impression is that it is rather a new plugin suggested on the top 
> of existing one, with breaking changes for current users
>
> On Thursday, October 17, 2019 at 7:32:34 AM UTC+2, Ullrich Hafner wrote:
>>
>>
>> Am 16.10.2019 um 19:58 schrieb Julio Guereca <[email protected]>:
>>
>> Hi All!!
>>
>> I am attempting to merge a pull request for a plugin (
>> https://github.com/jenkinsci/bigpanda-plugin/pull/1)
>>
>> Reading through some instructions, I did attempt to create a Jira ticket 
>> but could not find the *bigpanda-plugin *for the component field and 
>> didn't feel like I could move forward on this.
>>
>> I would like to know how I can either get this Pull Request approved or 
>> how I can approve it myself
>>
>>
>> Pull requests can only by approved by the development team of a plugin. 
>> So you need to wait for an approval (or merge) from that team. Since the 
>> last commit is five years ago I doubt that you get any responses. (I would 
>> help though that your PR title describes the actual changes in the PR).
>>
>> Did you already ping the developers of the plugin? Maybe this plugin 
>> looks for a new maintainer anyway...
>>
>> This is my first time attempting to publish a plugin for Jenkins so any 
>> guidance would be greatly appreciated.
>>
>> Thank you again for your time
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to [email protected].
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/22253d28-1c67-4413-b15f-9a2a7eedcb19%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/22253d28-1c67-4413-b15f-9a2a7eedcb19%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3df0496a-1441-4873-87f5-54b9c4b2d0fa%40googlegroups.com.

Reply via email to