+100 for switching from Jenkins JS Builder to a standard Webpack. According to experiments with jsbuilder it is pretty difficult to use this tool, especially for those ones who are not Javascript experts. Webpack is at least a standard tool, so it will be more convenient for newcomer Javascript contributors.
I do not have strong opinion about JEP for the Jenkins core. IMHO it is not strongly necessary there, because the implementation it is not exposed to plugin developers. If we go further and introduce a new framework/tooling instead of Jenkins JS Builder for plugins, then a JEP would be really nice. Some comments about the changes: 1. Once we have this implemented for the core, it would be nice to add a banner to https://github.com/jenkinsci/js-builder and https://github.com/jenkinsci/js-samples so that potential users see references to the new flow 2. I would really be happy to see https://github.com/jenkinsci/js-libs reworked or removed, but IIUC it is out of the scope (same for JS samples? https://github.com/jenkinsci/js-samples) - They were already deprecated by Jenkins JS Builder: https://github.com/jenkinsci/js-samples/blob/master/step-04-externalize-libs/HOW-IT-WORKS.md#configure-node-build-to-externalize-dependencies - We already have examples when plain NPM or Yarn are used in plugins. I'd guess webpack would be pretty similar Best regards, Oleg On Friday, January 10, 2020 at 11:22:37 AM UTC+1, Felix Queiruga wrote: > > I'll file the draft PR then. > > I already had in mind those TODOs that you mentioned. I wanted to get them > done before filing the PR. > > On Thursday, January 9, 2020 at 8:18:31 PM UTC+1, Jesse Glick wrote: >> >> On Thu, Jan 9, 2020 at 1:10 PM Felix Queiruga <fque...@cloudbees.com> >> wrote: >> > The branch can be found at >> https://github.com/fqueiruga/jenkins/tree/replace-jsbuilder-with-webpack. >> Keep in mind that it is a WIP >> >> You may want to file it as a draft PR—get early CI and have a place >> for early review comments to be placed. >> >> The diff is mostly beyond my comprehension, but as a general matter >> >> · avoid whitespace-only changes (revert ones you have made already, >> and configure your editor to not touch lines of text unless you are >> actually editing them) >> · delete rather than comment out obsolete sections of code >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c50209bf-1524-4a40-a4a6-9acf20ea5aee%40googlegroups.com.
