One thing here is that the most of the *pluginId-developers* teams are secret at the moment, and the teams must be public to operate properly with CODEOWNERS. I suggest to make all of them public, IMHO there is no value in hiding teams in the open-source project (apart form unintended mention prevention). I will add it to the next governance meeting, but I would appreciate the feedback
On Fri, Jan 10, 2020 at 12:31 PM Oleg Nenashev <[email protected]> wrote: > I'd guess any plugin maintainer can just proceed and add CODEOWNERS to the > repo. > There is no need to wait for the bot if you want to start adopting the > suggestion :) > > On Thursday, January 9, 2020 at 7:07:08 PM UTC+1, Gavin Mogan wrote: >> >> Sweet I was going to suggest the same thing.. >> >> Lots of plugin maintainers don't realize they are not "watching" a repo. >> and I think tools like pr bot don't count you unless your listed as a >> reviewer >> >> So much +1 for me >> >> On Thu., Jan. 9, 2020, 6:29 a.m. Oleg Nenashev, <[email protected]> >> wrote: >> >>> Perfect, this makes the barrier to acceptance quite low, without forcing >>>> a change on anyone. >>>> >>> Yes, I do not think we are in position to enforce the process at the >>> moment. Historically Jenkins project gives a lot of freedom to plugin >>> maintainers to define how they operate, and IMHO it is a part of the >>> project's culture. IMHO we should rather lead by example there and help by >>> providing tools and solutions simplifying the work and removing routine. >>> >>> On Thursday, January 9, 2020 at 3:04:51 PM UTC+1, Jesse Glick wrote: >>>> >>>> On Thu, Jan 9, 2020 at 8:05 AM Oleg Nenashev <[email protected]> >>>> wrote: >>>> > We add CODEOWNERS template to plugin archetypes >>>> >>>> Yes, though we need to do JENKINS-58557 first. >>>> >>>> > We submit pull requests […] >>>> > Each plugin maintainer or maintainer team will decide on their own >>>> whether they accept the process or not. Merging or closing the pull request >>>> will indicate the decision >>>> >>>> Perfect, this makes the barrier to acceptance quite low, without >>>> forcing a change on anyone. >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/f3f0b2d4-bb98-458d-9c96-ccdee1d1fec1%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/f3f0b2d4-bb98-458d-9c96-ccdee1d1fec1%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/U_lFkTzmg1E/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/bc4c21c0-a18c-467a-a02e-a26cfa5acd97%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/bc4c21c0-a18c-467a-a02e-a26cfa5acd97%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLATCB1R_OWLsEuGNoCx-k%2BqfQwJHxwvJOVbEFkgHWTW4A%40mail.gmail.com.
