Hi Oleg, Thanks for reviewing the document, I have updated and aligned the deliverables. I have also added the remaining sections. Additional reviews would be really helpful. Thanks and Cheers.
On Thu, Mar 5, 2020 at 3:02 PM Oleg Nenashev <[email protected]> wrote: > Hi Sladyn, > > Thanks for sharing it! I sent some comments in the Google document. > Overall it looks very promising, but right now there are many > inconsistencies between planned deliverables, planned scopes of changes and > the implementation plan. My suggestion would be to spend some time > proofreading the doc so that you can ensure that all sections are aligned. > > I am also not sure about putting the ChatOps into the scope, because it > has nothing to do with the Checks API (at least in a way it is documented > now). It is indeed a useful feature with high community value, but it may > deserve a separate project. I definitely would not recommend to commit on > delivering it, but it might be something to consider once the main > deliverables are implemented > > Best regards, > Oleg Nenashev > > > > On Tuesday, March 3, 2020 at 7:17:44 PM UTC+1, Sladyn Nunes wrote: >> >> Hello Everyone, >> This is a rough draft for my proposal for the GitHub Checks API. I have >> been working on it for some time, Feedback would be really appreciated. >> The proposal is still under construction but I would like to get early >> feedback on the direction I am going in. >> Here is the link: >> >> https://docs.google.com/document/d/1Gyii6QfCtvUU_Z7BtnuwXaNR5PbMgnVAJUxMTGfp9qs/edit?usp=sharing >> >> Here is a Proof Of Concept for the same.This is a simple Spring Service >> that starts a checks run on Github. >> I am planning to parse a warning File and add the warnings on GitHub to >> showcase my proposal.Feedback and ideas on this would also be highly >> appreaciated. >> This is the repository link for the POC. >> https://github.com/sladyn98/JenkinsChecksPOC >> >> Thanks and Cheers. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/e3e85f1d-d90c-4387-9961-6405f4593dd3%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/e3e85f1d-d90c-4387-9961-6405f4593dd3%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAC-LequFKKsR_RFX%3DCvYjFyF_1OADJDpuk6CO7pnttPVcWdh3w%40mail.gmail.com.
