Thanks guys, hopefully this would let me fully adopt and maintain the plugin, joining you.
Seems like its approved but I still get an unauthorised message. Do I need to put my artifactory permissions somewhere so mvn picks them up? Command for reference: mvn release:prepare release:perform On Sunday, May 24, 2020 at 10:46:53 PM UTC+3, Oleg Nenashev wrote: > > I will review it once I get to the computer. > > BR, Oleg > > On Sun, May 24, 2020, 21:45 'Gavin Mogan' via Jenkins Developers < > [email protected] <javascript:>> wrote: > >> There's only a couple people that can approve, and its a volunteer >> organization, its especially slow on weekends because people have family. >> It'll get done >> >> Gavin >> >> On Sun, May 24, 2020 at 12:42 PM Guy Sheffer <[email protected] >> <javascript:>> wrote: >> >>> Ok, waiting for someone with permissions to approve this: >>> https://github.com/jenkins-infra/repository-permissions-updater/pull/1536 >>> >>> On Friday, May 22, 2020 at 8:30:24 PM UTC+3, Richard Bywater wrote: >>>> >>>> Your current pom.xml file has a non-SNAPSHOT version in it. When doing >>>> a release the process expects (as far as I know) to find a SNAPSHOT >>>> version >>>> there, and the process then changes that to a non-SNAPSHOT, releases, and >>>> then ups the version number to the next SNAPSHOT number. >>>> >>>> Richard. >>>> >>>> On Fri, 22 May 2020 at 12:18, Guy Sheffer <[email protected]> wrote: >>>> >>>>> Ran that and got this: >>>>> >>>>> [INFO] >>>>> ------------------------------------------------------------------------ >>>>> [INFO] BUILD FAILURE >>>>> [INFO] >>>>> ------------------------------------------------------------------------ >>>>> [INFO] Total time: 25.037 s >>>>> [INFO] Finished at: 2020-05-22T03:17:54+03:00 >>>>> [INFO] >>>>> ------------------------------------------------------------------------ >>>>> [ERROR] Failed to execute goal >>>>> org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) >>>>> on project configurationslicing: You don't have a SNAPSHOT project in the >>>>> reactor projects list. -> [Help 1] >>>>> [ERROR] >>>>> [ERROR] To see the full stack trace of the errors, re-run Maven with >>>>> the -e switch. >>>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging. >>>>> [ERROR] >>>>> [ERROR] For more information about the errors and possible solutions, >>>>> please read the following articles: >>>>> [ERROR] [Help 1] >>>>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>>>> >>>>> >>>>> Am I doing something wrong? >>>>> >>>>> On Friday, May 22, 2020 at 2:56:19 AM UTC+3, Gavin Mogan wrote: >>>>>> >>>>>> a standard `mvn release:prepare release:perform` will do all the >>>>>> tagging and releasing for you >>>>>> >>>>>> On Thu, May 21, 2020 at 4:54 PM Guy Sheffer <[email protected]> wrote: >>>>>> >>>>>>> Ok, looks like it finally builds successfully in the CI. Should I >>>>>>> tag it and release? Or do we need to do more testing first? >>>>>>> >>>>>>> On Tuesday, May 19, 2020 at 1:11:51 PM UTC+3, Oleg Nenashev wrote: >>>>>>>> >>>>>>>> So you get static analysis errors from SpotBugs. >>>>>>>> It is important to review and clean up them eventually, but for the >>>>>>>> time being you can set a "spotbugs.failOnError" property to >>>>>>>> "false" in your pom.xml. In such case SpotBugs will not be failing the >>>>>>>> build >>>>>>>> >>>>>>>> Hopefully it helps, >>>>>>>> Oleg >>>>>>>> >>>>>>>> On Tue, May 19, 2020 at 12:07 PM Guy Sheffer <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Ok, compiles now, but I am getting errors on tests on the CI that >>>>>>>>> don't run when I use mvn package: >>>>>>>>> >>>>>>>>> ------------------------------------------------------------------------*12:51:38* >>>>>>>>> [ERROR] Failed to execute goal >>>>>>>>> com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check (spotbugs) on >>>>>>>>> project configurationslicing: failed with 13 bugs and 0 errors >>>>>>>>> >>>>>>>>> >>>>>>>>> Build: >>>>>>>>> https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/fix-ci/7/console >>>>>>>>> >>>>>>>>> On Sunday, May 17, 2020 at 5:23:11 PM UTC+3, Guy Sheffer wrote: >>>>>>>>>> >>>>>>>>>> Also, tried reverting back to hudson.queueSorter. >>>>>>>>>> >>>>>>>>>> Seems like there are broken methods now: >>>>>>>>>> >>>>>>>>>> [ERROR] Failed to execute goal org.apache.maven.plugins:maven- >>>>>>>>>> compiler-plugin:3.8.1:compile (default-compile) on project >>>>>>>>>> configurationslicing: Compilation failure: Compilation failure: >>>>>>>>>> [ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/ >>>>>>>>>> java/configurationslicing/tools/GradleSlicer.java:[52,52] cannot >>>>>>>>>> find symbol >>>>>>>>>> [ERROR] symbol: method getDescription() >>>>>>>>>> [ERROR] location: variable oldGradle of type hudson.plugins. >>>>>>>>>> gradle.Gradle >>>>>>>>>> [ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/ >>>>>>>>>> java/configurationslicing/tools/GradleSlicer.java:[57,50] cannot >>>>>>>>>> find symbol >>>>>>>>>> [ERROR] symbol: method isFromRootBuildScriptDir() >>>>>>>>>> [ERROR] location: variable oldGradle of type hudson.plugins. >>>>>>>>>> gradle.Gradle >>>>>>>>>> [ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/ >>>>>>>>>> java/configurationslicing/tools/GroovySlicer.java:[57,20] cannot >>>>>>>>>> find symbol >>>>>>>>>> [ERROR] symbol: variable DESCRIPTOR >>>>>>>>>> [ERROR] location: class hudson.plugins.groovy.Groovy >>>>>>>>>> [ERROR] -> [Help 1] >>>>>>>>>> [ERROR] >>>>>>>>>> [ERROR] To see the full stack trace of the errors, re-run Maven >>>>>>>>>> with the -e switch. >>>>>>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug >>>>>>>>>> logging. >>>>>>>>>> [ERROR] >>>>>>>>>> [ERROR] For more information about the errors and possible >>>>>>>>>> solutions, please read the following articles: >>>>>>>>>> [ERROR] [Help 1] http:// >>>>>>>>>> cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Sunday, May 17, 2020 at 5:14:27 PM UTC+3, Guy Sheffer wrote: >>>>>>>>>>> >>>>>>>>>>> Ok, now it fails on PrioritySorterSlicer.java:[5,26] package >>>>>>>>>>> hudson.queueSorter does not exist >>>>>>>>>>> >>>>>>>>>>> How do I import the new org.jenkins-ci.plugins:PrioritySorter? >>>>>>>>>>> >>>>>>>>>>> On Sunday, May 17, 2020 at 10:39:24 AM UTC+3, Guy Sheffer wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hey, >>>>>>>>>>>> Thanks that got me on the right track. >>>>>>>>>>>> Documented what I was doing here: >>>>>>>>>>>> >>>>>>>>>>>> https://issues.jenkins-ci.org/browse/JENKINS-61827?focusedCommentId=390808&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-390808 >>>>>>>>>>>> >>>>>>>>>>>> Now mvn validate says the build is successful. >>>>>>>>>>>> >>>>>>>>>>>> However, it seems not the CI on Jenkins isn't working, the >>>>>>>>>>>> nodes are stuck on AWS with a connection problem. >>>>>>>>>>>> >>>>>>>>>>>> For Example: >>>>>>>>>>>> https://ci.jenkins.io/computer/EC2%20(aws)%20-%20High%20memory%20ubuntu%2018.04%20%20(i-0785c260cbb2a05fa)/ >>>>>>>>>>>> >>>>>>>>>>>> On Sunday, April 19, 2020 at 6:44:21 PM UTC+3, Tim Jacomb wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Guy >>>>>>>>>>>>> >>>>>>>>>>>>> Timestamper and the two workflow plugins are in bom, I would >>>>>>>>>>>>> still recommend adding it, >>>>>>>>>>>>> >>>>>>>>>>>>> It looks like timestamper changed its group id at some point >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Tim >>>>>>>>>>>>> >>>>>>>>>>>>> On Sun, 19 Apr 2020 at 14:09, Guy Sheffer <[email protected]> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hey Tim, >>>>>>>>>>>>>> That bom (pom.xml) does not seem to hold most of the plugins >>>>>>>>>>>>>> used in Configuration Slicing plugin. This is because the plugin >>>>>>>>>>>>>> slices >>>>>>>>>>>>>> settings of many plugins. Each plugin is included as a >>>>>>>>>>>>>> dependency. >>>>>>>>>>>>>> >>>>>>>>>>>>>> You can grasp the size of the list here: >>>>>>>>>>>>>> https://github.com/jenkinsci/configurationslicing-plugin/blob/devel/pom.xml >>>>>>>>>>>>>> >>>>>>>>>>>>>> Just to make sure, I went over the plugins and made sure, >>>>>>>>>>>>>> indeed quite a lot, including email-ext, ant, groovy and others >>>>>>>>>>>>>> are not in >>>>>>>>>>>>>> that POM. >>>>>>>>>>>>>> I am fairly sure I managed to get all the dependencies under >>>>>>>>>>>>>> gorup-id org.jenkins-ci.plugins up to date. That was easy >>>>>>>>>>>>>> because the pages >>>>>>>>>>>>>> are for the plugins are documented. However I cam not sure about >>>>>>>>>>>>>> other >>>>>>>>>>>>>> settings. Such as timestamper in org.jvnet.hudson.plugins or >>>>>>>>>>>>>> plexus-utils >>>>>>>>>>>>>> in org.codehaus.plexus . >>>>>>>>>>>>>> >>>>>>>>>>>>>> This is the final step to get this plugin to build with the >>>>>>>>>>>>>> new support for pipeline, so if someone with more experience >>>>>>>>>>>>>> than me could >>>>>>>>>>>>>> take a look its likely something simple I overlooked. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks for helping out, >>>>>>>>>>>>>> Guy >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Monday, April 13, 2020 at 3:29:20 PM UTC+3, Tim Jacomb >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Normally you use the Jenkins bom >>>>>>>>>>>>>>> https://github.com/jenkinsci/bom >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Which includes the common plugins that are depended on, it >>>>>>>>>>>>>>> saves a lot of time when updating versions. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> Tim >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, 13 Apr 2020 at 12:44, Guy Sheffer <[email protected]> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks Oleg, >>>>>>>>>>>>>>>> To anyone that could help, >>>>>>>>>>>>>>>> I have got as far as updating all the versions by hand, but >>>>>>>>>>>>>>>> I am getting some RequireUpperBoundDeps errors. I am not sure >>>>>>>>>>>>>>>> what is the >>>>>>>>>>>>>>>> methodology to fix this, assuming now all the versions are up >>>>>>>>>>>>>>>> to date >>>>>>>>>>>>>>>> (which they might not be because I did this manually). >>>>>>>>>>>>>>>> I am really close to making a new release that supports >>>>>>>>>>>>>>>> pipeline build and would really appreciate figuring out this >>>>>>>>>>>>>>>> hopefully last >>>>>>>>>>>>>>>> step, will note that it does build on my local machine. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Guy >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> https://issues.jenkins-ci.org/browse/JENKINS-61827?filter=21951 >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Sunday, March 15, 2020 at 3:14:58 PM UTC+2, Guy Sheffer >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hey, here is the information as requested in >>>>>>>>>>>>>>>>> https://wiki.jenkins.io/pages/viewpage.action?pageId=103088172 >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> - >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Link to a plugin you want to adopt: >>>>>>>>>>>>>>>>> https://plugins.jenkins.io/configurationslicing/ >>>>>>>>>>>>>>>>> - >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Link(s) to pull requests you want to deliver, if >>>>>>>>>>>>>>>>> applicable: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> https://github.com/jenkinsci/configurationslicing-plugin/pull/21 >>>>>>>>>>>>>>>>> Note: this is not my code, however I want to build, >>>>>>>>>>>>>>>>> fix and manage the plugin >>>>>>>>>>>>>>>>> - >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Your GitHub username/id (e.g. oleg-nenashev for >>>>>>>>>>>>>>>>> https://github.com/oleg-nenashev/) >>>>>>>>>>>>>>>>> guysoft >>>>>>>>>>>>>>>>> - >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Your Jenkins infrastructure account id. Create your >>>>>>>>>>>>>>>>> account <https://accounts.jenkins.io/> if you don’t >>>>>>>>>>>>>>>>> have one: guysoft >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Also, I tried to build the plugin and the build fails >>>>>>>>>>>>>>>>> (test plugin fro the tutorial works fine). >>>>>>>>>>>>>>>>> So I want to fix that first. >>>>>>>>>>>>>>>>> Build output here if anyone can tell me what is going on: >>>>>>>>>>>>>>>>> https://pastebin.com/reU1DbAt >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>>>>>> Google Groups "Jenkins Developers" group. >>>>>>>>>>>>>>>> To unsubscribe from this group and stop receiving emails >>>>>>>>>>>>>>>> from it, send an email to [email protected]. >>>>>>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/1afbeb77-9f02-4e44-a8e4-38070deb864b%40googlegroups.com >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/1afbeb77-9f02-4e44-a8e4-38070deb864b%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>>>>>>>>> . >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>>>>> Google Groups "Jenkins Developers" group. >>>>>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>>>>> To view this discussion on the web visit >>>>>>>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/adeb4ba8-4c56-47d9-99b5-f499e5a1dc5d%40googlegroups.com >>>>>>>>>>>>>> >>>>>>>>>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/adeb4ba8-4c56-47d9-99b5-f499e5a1dc5d%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>>>>>>> . >>>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to a topic in >>>>>>>>> the Google Groups "Jenkins Developers" group. >>>>>>>>> To unsubscribe from this topic, visit >>>>>>>>> https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe >>>>>>>>> . >>>>>>>>> To unsubscribe from this group and all its topics, send an email >>>>>>>>> to [email protected]. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/74627f0e-d8c7-4b5d-b653-ad76730fb466%40googlegroups.com >>>>>>>>> >>>>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/74627f0e-d8c7-4b5d-b653-ad76730fb466%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Jenkins Developers" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/0c474f09-ff79-4d93-88e2-b8cde2fac531%40googlegroups.com >>>>>>> >>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/0c474f09-ff79-4d93-88e2-b8cde2fac531%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/7728bf67-24fe-4414-8b91-d15758dc4180%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/7728bf67-24fe-4414-8b91-d15758dc4180%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/2a829511-af0c-4e50-a71b-d16f24e90119%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/jenkinsci-dev/2a829511-af0c-4e50-a71b-d16f24e90119%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to a topic in the >> Google Groups "Jenkins Developers" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dus6f31ubRSOge1ao7U1yxEN6OuAYv4JOX8Qtv7PbAnjYw%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dus6f31ubRSOge1ao7U1yxEN6OuAYv4JOX8Qtv7PbAnjYw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1d9712e3-a777-47bb-893e-bea648af6cb4%40googlegroups.com.
