On Sun, Nov 29, 2020 at 1:11 AM Tim Jacomb <[email protected]> wrote:
> For the record commons-beanutils is provided by core at version 1.9.3 and > it’s in the core bom. > > If it’s a transitive dep I would have thought the bom would have corrected > the version, otherwise you can declare the dep without a version and scope > provided and the bom should handle it > > Thanks for the further insights. I think I've understood the fundamental mistake I made. When I switched from requiring Jenkins 2.204.1 to require Jenkins 2.222.4 as the minimum Jenkins version, switched to use the 2.222.x bom, and *removed the exclusion of commons-beanutils*, the GitStepTest.configRoundTrip automated test consistently failed with a JavaScript error. I could have continued using commons-validator 1.7 if I'd continued excluding commons-beanutils as a dependency of commons-validator 1.7. My desire to remove exclusions got in the way. The same issue would have been visible to me in Jenkins 2.204.1 if I had removed the exclusion of commons-beanutils from the commons-validator dependency. The root mistake I made was removing the exclusion of commons-beanutils. Removing that exclusion caused commons-beanutils 1.9.4 to be included in the git.hpi file. That inclusion broke the tests. The increase of minimum Jenkins version from 2.204.1 to 2.222.4 was not involved in the issue. The problem is resolved by https://github.com/jenkinsci/git-plugin/pull/1009 where the dependency on commons-validator is removed. Validating user input is important, but the checks that were being performed by commons-validator are not so much more valuable that I should wrestle with dependencies for them. Thanks for the insights! Mark Waite -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHZT6v%2Bjqo6LZLfxSWn_p-%2B0pnhV0DMfQ-dt13q5FsiMA%40mail.gmail.com.
