> Le 3 févr. 2021 à 15:21, Oleg Nenashev <[email protected]> a écrit : > > +1 for the first proposal, +0.5 for the second one. > In general we do not need the "always latest target" strategy for core > patches (and yes, ATH is massive...). Maybe we should keep it for LTS > backporting PRs if the configuration allows that > > > If the contributor want a new build, then the PR's originating branch must > > be updated to match the target branch. > > Currently Core Maintainers should be able to retrigger builds on-demand. > It should lead to re-merge with the target branch.
My understanding and experience with the "Build Strategy" option “Ignore rebuilding merge branches when only the target branch changed” is the following: PR-A opened: An initial build is triggered Then, the target branch is updated (PR-B has been merged): an event is sent to Jenkins, which will rebuild the target branch (of course: new commit), but it won’t re-trigger a build on PR-A The author of PR-A pushes to the branch after a rebase /merge from target’s branch: originating branch’s code is updated so Jenkins triggers a new build However I’m don’t know if a manual build is triggered, in Jenkins, between steps 2. and 3., if the build will do something. => Does it means that we might have different configuration between the multibranch jobs here (compared to a single GH Organization scanning)? Can the Pipeline of each repo override these 2 options per project? Damien > > BR, Oleg > > On Wednesday, February 3, 2021 at 3:14:05 PM UTC+1 [email protected] > <http://gmail.com/> wrote: > > Hello there, > > This is a proposal to make a configuration change for the GitHub organization > scanning "Core" on ci.jenkins.io <http://ci.jenkins.io/> > (https://ci.jenkins.io/job/Core <https://ci.jenkins.io/job/Core>). > > 2 items are targeted: > Filtering out, in the "Behavior" section, the PRs which has a label "on-hold" > or "ci-skip". > Goal: allow a contributor to open a PR without triggering a build > (<joke>build slots are scarce resources ;)</joke>) > We are currently doing this on the infra.ci.jenkins.io > <http://infra.ci.jenkins.io/> (as per > https://github.com/jenkins-infra/charts/pull/721 > <https://github.com/jenkins-infra/charts/pull/721> for instance) > Enabling the option “Ignore rebuilding merge branches when only the target > branch changed” in the section “Build Strategy” > Goal: avoid triggering a build for a given PR each time that the target is > updated > It allows deferring the "mergeability of the PR if up to date with target > branch" to GitHub. If the contributor want a new build, then the PR's > originating branch must be updated to match the target branch. > > I would like to know (learn?) if we can apply this without disrupting your > work and avoid costing too much time, while trying to add a new valuable > behavior and sparing some resources. > > The risks are related to the fact that applying this setting would impact all > of the following projects, members of the scanned organization: > jenkins-test-harness > jenkins-test-harness-htmlunit > sshd-module > slave-installer-module > windows-slave-installer-module > jenkins > pom > remoting > winstone > acceptance-test-harness > core-pr-tester > > Is there any objection to these changes? Anything that does not make sense? > > Cheers, > > Damien D. > > PS : If I obviously misunderstood something, or did not follow a specific > process, please pardon my "newbiness" here and point the mistake promptly so > I can change direction and improve > > > > > > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/FzX-Ph5U-6s/unsubscribe > <https://groups.google.com/d/topic/jenkinsci-dev/FzX-Ph5U-6s/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/10c7edf8-acd2-4e4a-86dd-3b7b7dc97534n%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/10c7edf8-acd2-4e4a-86dd-3b7b7dc97534n%40googlegroups.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/A166B1AF-D33F-4D9A-A46F-CC139F5AAD76%40gmail.com.
