Right - My timer never stopped. So my question is: who's responsible for calling "cancel()" on the timer? I assume I am.. but i'm not sure if this is really a "good practice". My current implementation is here:
https://github.com/bstopp/adobe-cloud-manager-plugin/blob/860f54a3ed9914939e339b04a1664fd21d85cf49/src/main/java/io/jenkins/plugins/adobe/cloudmanager/step/PollPipelineStep.java#L139-L156 Grateful for any pointers and/or criticism. Thanks! -B On Tue, Apr 27, 2021 at 9:44 AM Jesse Glick <[email protected]> wrote: > On Mon, Apr 26, 2021 at 11:04 PM Bryan Stopp <[email protected]> > wrote: > >> I'm getting an error: >> >> completed: already completed CpsStepContext >> >> after my timer has called the onSuccess method >> > > Somehow you are calling `onSuccess` and/or `onFailure` two or more times, > which is illegal. The warning is not fatal (subsequent calls are ignored) > but may be indicative of a real bug. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/TpUAft3fSxE/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1gK-7kdteh6-uJfWWQbqf%2B2s-tL-9LpwChGEa5fBVZ5w%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1gK-7kdteh6-uJfWWQbqf%2B2s-tL-9LpwChGEa5fBVZ5w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAGiOsN_za%3DqRk3aFZGsrmPyhZsARnpi0j5tq9z4fUvHQR9ZxVQ%40mail.gmail.com.
