Hi Tony, Thanks a lot for working on it! In this case I would be happy to just create a repo for you. Before we do so, what do you think about just renaming https://github.com/jenkinsci/xtrigger-lib ? It might be a more convenient approach if you keep the most of the codebase and do not need the old library implementation anymore.
Best regards, Oleg On Sun, May 16, 2021, 01:23 Tony Noble <[email protected]> wrote: > Dredging up an old conversation - apologies > > I've had chance to do some work on xtrigger-lib and convert to a plugin, > removing its dependency on envinject-lib in the process. I have a project > xtrigger-api-plugin ready to go, so really just a query as to what the next > step is - do I need to create my own repo which is then forked / moved into > jenkinsci org, or is it possible to just create an empty repo and make me > maintainer / owner? > > I assume artifact upload permissions will also need to be sorted, but from > memory that requires the github repo to exist first? > > Cheers, > > Tony > > On Mon, Dec 2, 2019 at 9:37 AM Tony Noble <[email protected]> wrote: > >> Brilliant, thanks :0) >> >> >> On Mon, Dec 2, 2019 at 7:39 AM Ullrich Hafner <[email protected]> >> wrote: >> >>> I added you as committer to the repositories. >>> >>> Am 02.12.2019 um 00:04 schrieb Tony Noble <[email protected]>: >>> >>> Late follow-up, apologies. >>> >>> Now I have time to look at outstanding PRs / Jira tickets, I still don't >>> appear to have owner access to the following git repos: >>> >>> - >>> - ScriptTrigger Plugin >>> <https://wiki.jenkins.io/display/JENKINS/ScriptTrigger+Plugin> - >>> https://github.com/jenkinsci/scripttrigger-plugin >>> - BuildResultTrigger Plugin >>> <https://wiki.jenkins.io/display/JENKINS/BuildResultTrigger+Plugin> >>> (a.k.a >>> JobTrigger) - https://github.com/jenkinsci/buildresult-trigger-plugin >>> >>> >>> All other access appears to be sorted, however. >>> >>> Can someone assist? >>> >>> Tony >>> >>> - >>> >>> >>> On Fri, Jul 26, 2019 at 1:47 PM Oleg Nenashev <[email protected]> >>> wrote: >>> >>>> done. Was waiting for more confirmations, but it got stalled >>>> >>>> On Fri, Jul 26, 2019 at 2:37 PM Tony Noble <[email protected]> >>>> wrote: >>>> >>>>> Pull request looks to have been approved, but not applied - can anyone >>>>> assist? >>>>> >>>>> Cheers, >>>>> >>>>> Tony >>>>> >>>>> On Sun, Jul 21, 2019 at 1:35 PM Tony Noble <[email protected]> >>>>> wrote: >>>>> >>>>>> Thanks Oleg, >>>>>> >>>>>> Pull request created: >>>>>> https://github.com/jenkins-infra/repository-permissions-updater/pull/1233 >>>>>> >>>>>> Tony >>>>>> >>>>>> On Sun, Jul 21, 2019 at 9:50 AM Oleg Nenashev <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Tony, >>>>>>> >>>>>>> I have granted you write access and made you a default assignee in >>>>>>> the components. >>>>>>> If you decide to become a maintainer of the EnvInject stuff, I will >>>>>>> be happy to grant your permissions as well. >>>>>>> >>>>>>> Some notes: >>>>>>> >>>>>>> - To release the components, you will need to create a pull >>>>>>> request to >>>>>>> https://github.com/jenkins-infra/repository-permissions-updater >>>>>>> - ColMelvin <https://github.com/ColMelvin> has contributed a lot >>>>>>> of patches which have not been released yet. IIRC I reviewed them 1 >>>>>>> year >>>>>>> ago, but nobody took ownership at that point. Some area for >>>>>>> collaboration >>>>>>> there, maybe >>>>>>> - For plugin you plan to maintain in longer term, it might make >>>>>>> sense to use Release Drafter for changelogs (docs >>>>>>> >>>>>>> <https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc> >>>>>>> ) >>>>>>> >>>>>>> Best regards, >>>>>>> Oleg >>>>>>> >>>>>>> On Saturday, July 20, 2019 at 9:30:49 PM UTC+2, Tony Noble wrote: >>>>>>>> >>>>>>>> Okay, so modifications: >>>>>>>> >>>>>>>> - No need to add me as maintainer for envinject-lib >>>>>>>> - XTrigger-lib plugin replacement will be named XTrigger-api-plugin >>>>>>>> >>>>>>>> On that basis, if someone could add me as maintainer for the rest, >>>>>>>> it'd be much appreciated. >>>>>>>> >>>>>>>> Tony >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Sat, Jul 20, 2019 at 7:15 PM Oleg Nenashev <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> My plan was to keep EnvInject Lib as a temporary lib until all >>>>>>>>> plugins and "libs" switch to EnvInject API. Then I would have moved >>>>>>>>> the >>>>>>>>> code and removed the library repository. It was at the time of a >>>>>>>>> Pipeline >>>>>>>>> compatibility effort 4 years ago. But we have not been able to rework >>>>>>>>> all >>>>>>>>> Geegory's plugins at that time, switched to other tasks. >>>>>>>>> >>>>>>>>> If you rework XTrigger Lib to a plugin, please use EnvInject API >>>>>>>>> Plugin as a dependency. >>>>>>>>> >>>>>>>>> BR, Oleg >>>>>>>>> >>>>>>>>> On Sat, Jul 20, 2019, 19:54 Daniel Beck <[email protected]> wrote: >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> > On 20. Jul 2019, at 14:52, Tony Noble <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> > >>>>>>>>>> > Another point to note - given that the goal for xtrigger-lib is >>>>>>>>>> to convert to a plugin, the natural name for it would be >>>>>>>>>> xtrigger-plugin. >>>>>>>>>> But that's obviously taken as noted above - rather than go off on >>>>>>>>>> the wrong >>>>>>>>>> track, would 'xtrigger-base-plugin' seem reasonable? >>>>>>>>>> > >>>>>>>>>> >>>>>>>>>> It's customary to name it whatever-api in Jenkins. envinject-lib >>>>>>>>>> is provided by the plugin 'envinject-api', there's branch-api and >>>>>>>>>> scm-api, >>>>>>>>>> etc. >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> You received this message because you are subscribed to a topic >>>>>>>>>> in the Google Groups "Jenkins Developers" group. >>>>>>>>>> To unsubscribe from this topic, visit >>>>>>>>>> https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe >>>>>>>>>> . >>>>>>>>>> To unsubscribe from this group and all its topics, send an email >>>>>>>>>> to [email protected]. >>>>>>>>>> To view this discussion on the web visit >>>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CFD98BB8-4683-4BB7-8101-D6FAEE28B4EC%40beckweb.net >>>>>>>>>> . >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "Jenkins Developers" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to [email protected]. >>>>>>>>> To view this discussion on the web visit >>>>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com >>>>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCe-d47xKn9wmOhen02%2BT0fxqXDF%3DQirp2MJqCSdPiCmQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>> . >>>>>>>>> >>>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "Jenkins Developers" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web visit >>>>>>> https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com >>>>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/6ea8aa69-4713-43af-ae1f-181dc37e9000%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to a topic in the >>>>> Google Groups "Jenkins Developers" group. >>>>> To unsubscribe from this topic, visit >>>>> https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe >>>>> . >>>>> To unsubscribe from this group and all its topics, send an email to >>>>> [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HA8ETqBpxbRODcsgZAEEkDPGQ8FRxe8d2hb3EHTNzGOQ%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9HA8ETqBpxbRODcsgZAEEkDPGQ8FRxe8d2hb3EHTNzGOQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBO%2By9BZ6pov64EAC%2BShoU46kTY_7Y1z%3DJ4Jn2T%2Bcq0vQ%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLBO%2By9BZ6pov64EAC%2BShoU46kTY_7Y1z%3DJ4Jn2T%2Bcq0vQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9E1caBcv9pQePQQ-eo1nJ6R_a-LSCyBGcN28N2iYVpXZw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9E1caBcv9pQePQQ-eo1nJ6R_a-LSCyBGcN28N2iYVpXZw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/0DF8F1F7-B99F-4CDD-918E-22E36B8011EF%40gmail.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/0DF8F1F7-B99F-4CDD-918E-22E36B8011EF%40gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/Ue9hmTRhqS4/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9H-bqrGOVN_4XWEZS6hfwBQJA5yEBq6QHsrE2LCeNUQhg%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9H-bqrGOVN_4XWEZS6hfwBQJA5yEBq6QHsrE2LCeNUQhg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAJGAqpxeO_VX0oysy%2BV91ojBJK36QybROUXb00e%2Ba0dQ%40mail.gmail.com.
