Thanks for the pointer!

I came up with theese changes to implement the `Job.displayName` variant: 
https://github.com/jenkinsci/branch-api-plugin/pull/254 The tests are 
really unhappy about my call to `getAction` =(

However I only consider this a POC at this point and would like to get 
feedback from the maintainers on the change in general before spending the 
required time to implement this properly.

GitHub didn't assign reviewers automatically... how do I request proper 
review for this broad change?

On Tuesday, 25 May 2021 at 21:32:36 UTC+2 Jesse Glick wrote:

> On Tue, May 25, 2021 at 1:41 PM [email protected] <[email protected]> wrote:
>
>> Or do you recommend to implement this feature in the scm-api plugin?
>>
>
> The API is already defined, and might already be implemented in 
> `gitlab-branch-source` (no idea offhand): 
> https://javadoc.jenkins.io/plugin/scm-api/jenkins/scm/api/metadata/ObjectMetadataAction.html#getObjectDisplayName--
>  
>
> As to how it is *used*, that is another question, outside the control 
> of `gitlab-branch-source`. The `Job.displayName` could be set by the 
> `branch-api` plugin, though it is probably better to set a 
> `Job.description` (for display in the project index page) and maybe add a 
> new list view column to the `change-requests` view.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/991caede-223f-4b98-a7ac-97198e63713dn%40googlegroups.com.

Reply via email to