On Mon, Jun 14, 2021 at 7:36 PM Jesse Glick <[email protected]> wrote: > > JNR may be a similar story. I see all of two usages in core—both disabled > unless you set a system property. Just deleting it all may be easier
I had already noticed that as well and thought about opening such a PR to delete all usages of JNR. I decided to settle for removing `jna-posix` first. :-) But regarding removing JNR, what if someone is relying on that system property? Unlike API changes, where I can easily check `usage-in-plugins` to see how many plugins (both open source and CloudBees-proprietary) are still using a given API, there is no equivalent for me to check how many installations are relying on a given system property being said. This makes me a bit nervous to remove it. How has the Jenkins project handled cases like this historically? I can give one example of how I handled a similar situation in Email Extension. In 2.78 [1] (October 2020) I announced in the release notes that "integration with the Static Analysis Utilities plugin has been deprecated in the Email Extension plugin and will be removed in a future release", linking to the relevant Jira issue. In 2.81 [2] (January 2021) I again announced in the release notes (more strongly this time) that "integration with the Static Analysis Utilities plugin was deprecated in 2.78 and is scheduled to be removed in the first quarter of 2021", again linking to the relevant Jira issue. In 2.82 [3] (March 2021), I pulled the plug and announced in the release notes that "as of 2.82, integration with the Static Analysis Utilities plugin has been removed from the Email Extension plugin". I gave users a chance to speak up. Nobody spoke up. I gave users a second chance to speak up. Nobody spoke up. I pulled the plug. Nobody complained. I think it went pretty well. Perhaps this might be a pattern worth following in Jenkins core? [1] https://github.com/jenkinsci/email-ext-plugin/releases/tag/email-ext-2.78 [2] https://github.com/jenkinsci/email-ext-plugin/releases/tag/email-ext-2.81 [3] https://github.com/jenkinsci/email-ext-plugin/releases/tag/email-ext-2.82 -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrdCq8Tz_WfcD4TQwLzTgp5K-q3_PXqodJ%2BX8zEM7fSOw%40mail.gmail.com.
