I replied on the PR. You aren't using the sshd provided copy but instead are using the jenkins cli one
On Fri, 6 Aug 2021 at 16:08, Mark Waite <[email protected]> wrote: > The git credentials binding project in Google Summer of Code is making > progress on private key support. Private keys are working on Windows with > investigation exploring non-Windows environments. > > The pull request <https://github.com/jenkinsci/git-plugin/pull/1111> > includes a reference to the sshd-core library from the Apache Mina > project. That reference allows the plugin to read and write private key > files, including passphrase protected private key files. However, that > reference also causes two unrelated automated tests > <https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1111/8/testReport/> > to fail with the message: > > java.lang.ClassNotFoundException: > org.jenkinsci.main.modules.sshd.SshCommandFactory > at java.net.URLClassLoader.findClass(URLClassLoader.java:382) > at java.lang.ClassLoader.loadClass(ClassLoader.java:418) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352) > at java.lang.ClassLoader.loadClass(ClassLoader.java:351) > Caused: java.lang.NoClassDefFoundError: > org/jenkinsci/main/modules/sshd/SshCommandFactory > at java.lang.ClassLoader.defineClass1(Native Method) > > The Apache Mina classes are referenced through their shaded location > <https://github.com/jenkinsci/git-plugin/pull/1111/files#r684308266> as > provided by the sshd plugin. That works at runtime (at least on Windows), > but causes these test failures. > > Any guidance on the preferred approach to use a library (sshd-core) that > is part of a plugin (sshd) that was previously part of Jenkins core? > > Mark Waite > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/016fd04a-f2e5-45e8-9ece-b7a89353ce33n%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/016fd04a-f2e5-45e8-9ece-b7a89353ce33n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bid9NR1bhdH6ndiVQsYgM199wDHaioaKWRSQ5cb2xBPORQ%40mail.gmail.com.
