Already done in jnr/jnr-ffi#269 jenkinsci/jenkins#5712 On Mon, Sep 6, 2021 at 9:36 AM jn...@cloudbees.com <jn...@cloudbees.com> wrote:
> You just beat me to it! > > creating the PRs. > > On Monday, September 6, 2021 at 5:28:34 PM UTC+1 m...@basilcrow.com wrote: > >> It's jenkinsci/jenkins#5703, which pulled in jnr/jnr-ffi#252, which >> updated JUnit from 4 to 5 in jnr-ffi without putting the new JUnit 5 >> JAR in the test scope. That means the following JARs are now >> (erroneously) bundled in the Jenkins WAR: >> >> [INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.7.2:compile >> [INFO] | +- org.apiguardian:apiguardian-api:jar:1.1.0:compile >> [INFO] | +- org.junit.platform:junit-platform-engine:jar:1.7.2:compile >> [INFO] | | +- org.opentest4j:opentest4j:jar:1.2.0:compile >> [INFO] | | \- org.junit.platform:junit-platform-commons:jar:1.7.2:compile >> [INFO] | \- org.junit.jupiter:junit-jupiter-api:jar:5.7.2:compile >> >> Needless to say, we don't want these in the WAR, and their mere >> presence on the classpath exposes us to SUREFIRE-1911, so we should >> exclude them and file an upstream issue to fix jnr/jnr-ffi#252 by >> putting these dependency in test scope. >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to jenkinsci-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/760ce5a3-4f48-4828-83fd-23fd4230879bn%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/760ce5a3-4f48-4828-83fd-23fd4230879bn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqUDYjPKxWbMvO8iL2AyzPRFpc6n%3DC6sd8BW5Mt9ObxKA%40mail.gmail.com.
