Weird, why did i merge https://github.com/jenkins-infra/repository-permissions-updater/pull/2210 when the template wasn't filled out.
We never gave you github access, the template has a field to indicate if you need github access as well. I'll run it now. Gavin On Sun, Dec 12, 2021 at 5:14 AM 'Réda Housni Alaoui' via Jenkins Developers <[email protected]> wrote: > Hi Mark, > > I just tried to push to the adopted repository and it fails with: > > ERROR: Permission to jenkinsci/sonar-gerrit-plugin.git denied to > reda-alaoui. fatal: Could not read from remote repository. Please make sure > you have the correct access rights and the repository exists. > > I first thought it was because I provided my jenkinsci username instead of > my github username in the PR. > But given > https://github.com/jenkins-infra/repository-permissions-updater/pull/2243/checks?check_run_id=4497955598, > I came to the conclusion that is was not culprit. > > Can you help me with this please? > > Best regards > > Le dimanche 28 novembre 2021 à 20:13:14 UTC+1, Mark Waite a écrit : > >> Please submit a pull request to the repository permissions updater >> repository >> <https://github.com/jenkins-infra/repository-permissions-updater> that >> proposes to make you a maintainer of that plugin. >> >> On Sun, Nov 28, 2021 at 12:06 PM 'Réda Housni Alaoui' via Jenkins >> Developers <[email protected]> wrote: >> >>> Hello, >>> >>> So 2 weeks have passed. What's the next step? :) >>> >>> Le dimanche 14 novembre 2021 à 12:59:07 UTC+1, Mark Waite a écrit : >>> >>>> +1 from me for the adoption. Since the referenced request was not a >>>> specific request to adopt the plugin, I think we should start the two week >>>> timer for the adoption request and complete the adoption in two weeks. >>>> >>>> On Sunday, November 14, 2021 at 4:55:55 AM UTC-7 [email protected] >>>> wrote: >>>> >>>>> Hello Mark, >>>>> >>>>> Yes I am. >>>>> >>>>> On November 14, 2021, Mark Waite <[email protected]> wrote: >>>>> >>>>> Thanks for your interest in adopting the plugin. That plugin has a >>>>> known security vulnerability as described at >>>>> https://www.jenkins.io/security/advisory/2019-10-23/#SECURITY-1003 . >>>>> That vulnerability would need to be fixed in addition to the merge of the >>>>> pull request that you're proposing. >>>>> >>>>> Would you also be willing to fix that vulnerability by modifying the >>>>> plugin to use Jenkins credentials? >>>>> >>>>> Mark Waite >>>>> >>>>> On Sunday, November 14, 2021 at 3:53:17 AM UTC-7 Réda Housni Alaoui >>>>> wrote: >>>>>> >>>>>> Hi everyone, >>>>>> >>>>>> I'd like to adopt https://plugins.jenkins.io/sonar-gerrit/ for the >>>>>> following reasons: >>>>>> >>>>>> - the plugin hasn't seen any release for 2 years >>>>>> - since the last Sonarqube LTS version, the plugin needs >>>>>> https://github.com/jenkinsci/sonar-gerrit-plugin/pull/38. The PR >>>>>> has been opened for 1 year without any reaction from the maintainer >>>>>> https://github.com/aquarellian >>>>>> - the maintainer does not reply to pinging ( >>>>>> >>>>>> https://github.com/jenkinsci/sonar-gerrit-plugin/pull/38#issuecomment-953003777 >>>>>> ) >>>>>> >>>>>> >>>>>> I want to deliver >>>>>> https://github.com/jenkinsci/sonar-gerrit-plugin/pull/39 (which is a >>>>>> rework of https://github.com/jenkinsci/sonar-gerrit-plugin/pull/38). >>>>>> >>>>>> My github username is https://github.com/reda-alaoui . >>>>>> My Jenkins infrastructure account id is *reda_alaoui* . >>>>>> >>>>>> Best regards >>>>>> >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/0e766256-2f08-4b3c-85b3-4c950669fd49n%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/0e766256-2f08-4b3c-85b3-4c950669fd49n%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Jenkins Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> >> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/jenkinsci-dev/cdcca73f-c5f1-45dd-85b9-f3451990bd59n%40googlegroups.com >>> <https://groups.google.com/d/msgid/jenkinsci-dev/cdcca73f-c5f1-45dd-85b9-f3451990bd59n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/b4e8605a-a265-491a-b70b-5e166965c871n%40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/b4e8605a-a265-491a-b70b-5e166965c871n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DuvjDm9%2BJ%2B0EOivwrbXBFKmEZaR2C5APkDqx8PJ4rg9s3A%40mail.gmail.com.
