Great. Will you review my currently open changes? Or do you expect me to merge them myself?
On Monday, September 26, 2022 at 10:46:23 PM UTC+2 lucamilanesio wrote: > > On 26 Sep 2022, at 14:01, 'Réda Housni Alaoui' via Jenkins Developers < > [email protected]> wrote: > > Thank you ! > > On Monday, September 26, 2022 at 2:31:34 PM UTC+2 lucamilanesio wrote: > >> >> On 26 Sep 2022, at 12:57, 'Réda Housni Alaoui' via Jenkins Developers < >> [email protected]> wrote: >> >> Hello Luca ! >> >> > Where di you see this status? >> >> Sorry I wrongly copy pasted another adoption request :X >> >> > I’d be happy to give you more permissions and reviews assigned on the >> project: I definitely need more help to develop it. >> > However, I’d like to keep the ownership of the plugin. >> > What do you think? >> >> I created this adoption request because there has been no new commit >> since December 2021. I thought you had no more time for this plugin >> (because of the 1000 other plugins you lead :D ) . >> I only want to see my changes reviewed and eventually merged when it make >> sense :) >> >> So yes, please keep the ownership and thank you for your efforts and this >> wonderful plugin ! >> >> >> I’ll add you Code-Review +2 permissions on review.gerrithub.io, I trust >> your reliability and dedication to OpenSource, thanks for all your help so >> far. >> > > All done, you can now approve changes on the plugin. > > Luca. > > >> >> It'd be an honor to have more permission on the plugin. But please note >> that I am not sure to have enough bandwidth to review other people >> contributions. >> >> >> I’ll definitely appreciate any additional help you could provide, without >> commitments. >> >> Luca. >> >> >> On Monday, September 26, 2022 at 1:45:47 PM UTC+2 lucamilanesio wrote: >> >>> >>> >>> On 26 Sep 2022, at 12:27, 'Réda Housni Alaoui' via Jenkins Developers < >>> [email protected]> wrote: >>> >>> Hi, >>> >>> >>> Hi Reda, >>> I am the owner of the plugin, thanks for offering your help to work on >>> the plugin. >>> >>> I’d be delighted to have you onboard with me, you also contributed a lot >>> to other of my plugins, including the Jira integration for Gerrit Code >>> Review. >>> >>> >>> I would like to adopt a plugin: >>> >>> - *Link*: https://github.com/jenkinsci/gerrit-code-review-plugin >>> <https://github.com/jenkinsci/run-condition-plugin> >>> - *Pull requests*: >>> - >>> >>> https://review.gerrithub.io/c/jenkinsci/gerrit-code-review-plugin/+/526905 >>> - >>> >>> https://review.gerrithub.io/c/jenkinsci/gerrit-code-review-plugin/+/527041 >>> - >>> >>> https://review.gerrithub.io/c/jenkinsci/gerrit-code-review-plugin/+/526993 >>> - >>> >>> https://review.gerrithub.io/c/jenkinsci/gerrit-code-review-plugin/+/526430 >>> >>> We do the reviews on GerritHub.io <http://gerrithub.io/>, see the open >>> changes at: >>> >>> https://review.gerrithub.io/q/project:jenkinsci/gerrit-code-review-plugin+status:open >>> >>> I’ll add my reviews today. >>> >>> >>> - *Status*: for adoption >>> >>> >>> Where di you see this status? >>> >>> >>> - *GitHub Username*: reda-alaoui <https://github.com/reda-alaoui> >>> - *Jenkins Infrastructure ID*: reda_alaoui >>> >>> Best regards >>> >>> >>> I’d be happy to give you more permissions and reviews assigned on the >>> project: I definitely need more help to develop it. >>> However, I’d like to keep the ownership of the plugin. >>> >>> What do you think? >>> >>> Luca. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/d56ba900-2bcf-474b-a9e7-4773b813f89bn%40googlegroups.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/d56ba900-2bcf-474b-a9e7-4773b813f89bn%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/d550ba57-6c36-4e15-b7d2-a7a31eda1dden%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/d550ba57-6c36-4e15-b7d2-a7a31eda1dden%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ae938281-57f6-4924-9eab-44063eca62bfn%40googlegroups.com.
