Thank you all for help. We can see our plugin is published to market place. Appreciated all the guidance and support.
On Thu, Nov 30, 2023 at 2:30 PM 'Gavin Mogan' via Jenkins Developers < [email protected]> wrote: > we usually say up to 3 hours since multiple parts have to line up, but > could be up to 6 if you miss a window. > > > https://github.com/jenkins-infra/plugin-site/blob/master/Jenkinsfile_k8s#L57 > runs every 3hours > It uses data from update center (which I can't find the config for, but > run every 5 or 15 min i forgot) > > On Thu, Nov 30, 2023 at 11:23 AM Adrien Lecharpentier < > [email protected]> wrote: > >> I don't recall exactly but someone in the community might know exactly >> >> Le jeu. 30 nov. 2023, 18:59, naveen sharma <[email protected]> a >> écrit : >> >>> Hi Adrien, Please suggest What's the frequency to update The plugin site >>> (plugins.jenkins.io). We are announcing it shortly and expecting to be >>> available on plugins.jenkins.io. >>> >>> On Thu, Nov 30, 2023 at 11:52 AM naveen sharma <[email protected]> >>> wrote: >>> >>>> Got it. I will work with Will to delete original repo this, once we >>>> validate plugin on marketplace. >>>> >>>> The plugin site (plugins.jenkins.io) will be updated soon. -- Within 1 >>>> hr? or less >>>> >>>> >>>> On Thu, Nov 30, 2023 at 11:43 AM Adrien Lecharpentier < >>>> [email protected]> wrote: >>>> >>>>> So, there is a release. >>>>> The release is available in the update center ( >>>>> https://updates.jenkins.io/current/update-center.json) >>>>> >>>>> The plugin site (plugins.jenkins.io) will be updated soon. >>>>> >>>>> One thing, for the hosting process, we request that the original >>>>> repository of the plugin be deleted so that the one in jenkinsci >>>>> organization is not seen as a fork. >>>>> >>>>> >>>>> >>>>> Le jeu. 30 nov. 2023, 17:32, naveen sharma <[email protected]> a >>>>> écrit : >>>>> >>>>>> Hi Adrien, >>>>>> >>>>>> Quick help >>>>>> >>>>>> We have this final PR >>>>>> https://github.com/jenkinsci/amazon-inspector-image-scanner-plugin/pull/3#issuecomment-1834108500 >>>>>> >>>>>> Please suggest by when we can see our plugin to marketplace. >>>>>> >>>>>> Regards, >>>>>> Naveen >>>>>> >>>>>> On Wed, Nov 29, 2023 at 6:28 PM naveen sharma <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Thank you for your help! >>>>>>> >>>>>>> On Wed, Nov 29, 2023 at 5:34 PM Adrien Lecharpentier < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> I saw that you tried to enable CD on the repository but the action >>>>>>>> description is not located in the correct directory. >>>>>>>> >>>>>>>> The file must be in `.github/workflows`. >>>>>>>> >>>>>>>> Then you will need to label a pull request with the label >>>>>>>> `developer` for example. (Use the one you'll use to fix the cd action >>>>>>>> file). Once the pull request is merged, you should see a new release. >>>>>>>> >>>>>>>> Le mer. 29 nov. 2023, 23:16, Adrien Lecharpentier < >>>>>>>> [email protected]> a écrit : >>>>>>>> >>>>>>>>> Yes you need. >>>>>>>>> Everything is detailed here >>>>>>>>> https://www.jenkins.io/doc/developer/publishing/releasing/ >>>>>>>>> >>>>>>>>> Le mer. 29 nov. 2023, 21:40, naveen sharma <[email protected]> >>>>>>>>> a écrit : >>>>>>>>> >>>>>>>>>> Hi Adrien, do we need permission for publishing plugin ? >>>>>>>>>> >>>>>>>>>> Can you suggest process please >>>>>>>>>> >>>>>>>>>> On Wed, Nov 29, 2023 at 11:26 AM naveen sharma < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Thank you Adrien for all the help. Appreciated. >>>>>>>>>>> >>>>>>>>>>> When we publish do we have any delay or plugin show in few >>>>>>>>>>> minutes to marketplace. >>>>>>>>>>> >>>>>>>>>>> On Tue, Nov 28, 2023 at 3:06 PM naveen sharma < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Adrien, We updated as you suggested >>>>>>>>>>>> https://github.com/aws/amazon-inspector-container-image-scanner-jenkins-plugin/commit/8440e44c203edf6655dff95ec26994cfa5d5c9c9 >>>>>>>>>>>> >>>>>>>>>>>> Please review and help approving. >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Nov 28, 2023 at 10:09 AM naveen sharma < >>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Adrien, Greetings for the day. >>>>>>>>>>>>> >>>>>>>>>>>>> Team saying can we get approval and do some research later for >>>>>>>>>>>>> credentialid solution as other important functionality is getting >>>>>>>>>>>>> blocked >>>>>>>>>>>>> which is customer commitment features in plugin. Please help >>>>>>>>>>>>> approving >>>>>>>>>>>>> hosting request. Let me know if you need more information. >>>>>>>>>>>>> >>>>>>>>>>>>> Thank you for your support. >>>>>>>>>>>>> >>>>>>>>>>>>> Regards, >>>>>>>>>>>>> Naveen >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Nov 28, 2023 at 4:09 AM Adrien Lecharpentier < >>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> I put a link in my comment on the issue to the documentation >>>>>>>>>>>>>> of the credentials plugin. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Le lun. 27 nov. 2023, 23:36, naveen sharma < >>>>>>>>>>>>>> [email protected]> a écrit : >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Sure, Can you please help looping security reviewer as well >>>>>>>>>>>>>>> and suggest what is correct way to handle this? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Nov 27, 2023 at 4:40 PM Adrien Lecharpentier < >>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I understand the optionality if it, yet I don't think the >>>>>>>>>>>>>>>> current implementation is correct. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Le lun. 27 nov. 2023, 21:53, naveen sharma < >>>>>>>>>>>>>>>> [email protected]> a écrit : >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Docker credentials is optional field and this needed only >>>>>>>>>>>>>>>>> if specific user need to scan their private repo. Other wise >>>>>>>>>>>>>>>>> whole thing >>>>>>>>>>>>>>>>> run on aws authorized IAM >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Mon, Nov 27, 2023 at 3:50 PM naveen sharma < >>>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Appreciate your help on this. Please get review with >>>>>>>>>>>>>>>>>> security folks and help us getting approval. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Nov 27, 2023 at 3:21 PM Adrien Lecharpentier < >>>>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> The username form the docker is a problem to me. I would >>>>>>>>>>>>>>>>>>> like someone from security team to weight on this. >>>>>>>>>>>>>>>>>>> Transforming it after >>>>>>>>>>>>>>>>>>> the first release will be complicated as you I'll have to >>>>>>>>>>>>>>>>>>> deal with the >>>>>>>>>>>>>>>>>>> data transformation from the simple username storage to >>>>>>>>>>>>>>>>>>> using a >>>>>>>>>>>>>>>>>>> credentialId. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I will try to find some time on Tuesday to review the >>>>>>>>>>>>>>>>>>> rest of the plugin. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I spot the usage File to create folders based on >>>>>>>>>>>>>>>>>>> environment variable which I don't understand why to do >>>>>>>>>>>>>>>>>>> that, and if it's >>>>>>>>>>>>>>>>>>> portable. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I don't know how long all that will take. >>>>>>>>>>>>>>>>>>> That's why I said to start the processus as soon as >>>>>>>>>>>>>>>>>>> possible. >>>>>>>>>>>>>>>>>>> Understand that most of us do those reviews in our spare >>>>>>>>>>>>>>>>>>> time. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Le lun. 27 nov. 2023, 21:09, naveen sharma < >>>>>>>>>>>>>>>>>>> [email protected]> a écrit : >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi Adrian, we saw your comments are they any launch >>>>>>>>>>>>>>>>>>>> blocker or can be addressed after launch. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> This need to be announced on 30th and we need help >>>>>>>>>>>>>>>>>>>> publishing plugin. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Please suggest >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Mon, Nov 27, 2023 at 11:48 AM naveen sharma < >>>>>>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi Adrian, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Greetings for the day. Can you please review and >>>>>>>>>>>>>>>>>>>>> approve Plugin under hosting request >>>>>>>>>>>>>>>>>>>>> https://github.com/jenkins-infra/repository-permissions-updater/issues/3634#issuecomment-1828206877 >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> We need to plublish this on marketplace on 30th Nov >>>>>>>>>>>>>>>>>>>>> 2023 around 7:30 AM PST. Please guide me on the same as >>>>>>>>>>>>>>>>>>>>> well. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Regards, >>>>>>>>>>>>>>>>>>>>> Naveen >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyF%2Bmee1ebtcGra2rE63zhMdAuj7hkcO%2Bs7Wsb1CAcZAA%40mail.gmail.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvyF%2Bmee1ebtcGra2rE63zhMdAuj7hkcO%2Bs7Wsb1CAcZAA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duufc9kNVSDV3SBmeSb7aiLLAC2dKHqVx_r6jZa%2Bru8zTA%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duufc9kNVSDV3SBmeSb7aiLLAC2dKHqVx_r6jZa%2Bru8zTA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAASPd53nY%2BWT-d4ubsMtacASEKHpC3oMPWzCCXvZx63hwLPPvw%40mail.gmail.com.
